From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8660D14BD6B; Thu, 29 Feb 2024 20:37:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709239057; cv=none; b=GohpmVkW9fk3rzEZAGBD1x3dCRBp2a+84mDP4hSXt3SWrbOV7BX3x/QjubxiVHwi1EHmHfszq2HdoDiRlio+v3nTq4fhW6MNxeIWbTMgHPNYagGFUO8t7ApJe7Cy1sgYgAZ/QzKmiSmm+kSJ60oSE0NdBKnX+7Vti8elEoMGgdk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709239057; c=relaxed/simple; bh=KSF7boKFkFUKI5Y7wTzgbmgkVIR1+Hf5SXgY2kEF1mA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S/NjcANilMJLvqm0wD2L8uYrj6e621MhRfrx0/flrBI5SPeZMvcvEO+Aj8Z89otX4lhl7HmItaoNEhNc2wvsE/u7iisj9jqi0PDfqcG6rs8SIYFzHOVaVHLouSdmfh8FsAiGP+7dN/WWPZ7Q4Uanjv2DRUYzBbKs9z1TncaYCt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F5MzDG27; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F5MzDG27" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A4EFC43601; Thu, 29 Feb 2024 20:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709239057; bh=KSF7boKFkFUKI5Y7wTzgbmgkVIR1+Hf5SXgY2kEF1mA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F5MzDG275d9ygPLK2OsPvrKZgNJE9HYc3UT9VhEN3t8OEXUb2OOAPtT1zdc5KMyhP jOjSTbX0po5NP60GQHJ3UmleKOOv5CMXaNcP+kHEN6IGhfBVjvoxRPvofwOJeZojJM RNRoqlgswzLR1knphzJruK0in3zOAWSv8vixKvyoMV2z3qB0y5xW9gAO+6l04ttDFd Utx/T8SKGQYHbL3pd9+MB6RJZJ031LVaVKXzicIVGQdqcmZTMxIFfPzVvy0JCbWqTV UrgoDEh+6qsB8zbpLlOC6xx40MzbDwPB0mnOE6ymg3N6pBdmsVGXTG0HOFXiZBPxDP 92Exbdu8vcsrw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yishai Hadas , Tamar Mashiah , Michael Guralnik , Leon Romanovsky , Sasha Levin , linux-rdma@vger.kernel.org Subject: [PATCH AUTOSEL 6.7 04/24] RDMA/mlx5: Relax DEVX access upon modify commands Date: Thu, 29 Feb 2024 15:36:44 -0500 Message-ID: <20240229203729.2860356-4-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229203729.2860356-1-sashal@kernel.org> References: <20240229203729.2860356-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.7.6 Content-Transfer-Encoding: 8bit From: Yishai Hadas [ Upstream commit be551ee1574280ef8afbf7c271212ac3e38933ef ] Relax DEVX access upon modify commands to be UVERBS_ACCESS_READ. The kernel doesn't need to protect what firmware protects, or what causes no damage to anyone but the user. As firmware needs to protect itself from parallel access to the same object, don't block parallel modify/query commands on the same object in the kernel side. This change will allow user space application to run parallel updates to different entries in the same bulk object. Tested-by: Tamar Mashiah Signed-off-by: Yishai Hadas Reviewed-by: Michael Guralnik Link: https://lore.kernel.org/r/7407d5ed35dc427c1097699e12b49c01e1073406.1706433934.git.leon@kernel.org Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/mlx5/devx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx5/devx.c b/drivers/infiniband/hw/mlx5/devx.c index 8ba53edf23119..6e19974ecf6e7 100644 --- a/drivers/infiniband/hw/mlx5/devx.c +++ b/drivers/infiniband/hw/mlx5/devx.c @@ -2949,7 +2949,7 @@ DECLARE_UVERBS_NAMED_METHOD( MLX5_IB_METHOD_DEVX_OBJ_MODIFY, UVERBS_ATTR_IDR(MLX5_IB_ATTR_DEVX_OBJ_MODIFY_HANDLE, UVERBS_IDR_ANY_OBJECT, - UVERBS_ACCESS_WRITE, + UVERBS_ACCESS_READ, UA_MANDATORY), UVERBS_ATTR_PTR_IN( MLX5_IB_ATTR_DEVX_OBJ_MODIFY_CMD_IN, -- 2.43.0