From: Kees Cook <keescook@chromium.org>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
oe-kbuild-all@lists.linux.dev, kernel test robot <lkp@intel.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: Fix UNWIND_HINT_{SAVE,RESTORE} across basic blocks
Date: Thu, 29 Feb 2024 22:33:13 -0800 [thread overview]
Message-ID: <202402292232.2D9E913F@keescook> (raw)
In-Reply-To: <20240227073527.avcm5naavbv3cj5s@treble>
On Mon, Feb 26, 2024 at 11:35:27PM -0800, Josh Poimboeuf wrote:
> On Fri, Feb 23, 2024 at 04:45:22PM -0800, Kees Cook wrote:
> > Josh, Peter, can you give a clue about what's happened here? For
> > added context, the referenced commit is changing a noreturn function
> > prototype[1], which I know gets some special objtool handling, but it's
> > converting a pointer arg to a u8... I can't imagine what has gone weird
> > here. :P
>
> I think this convinced GCC to reshuffle some basic blocks, which
> uncovered an objtool bug. Or, objtool just wasn't smart enough, as the
> warning says ;-)
>
> This should fix it, absent any more warnings. Kees, feel free to take
> it in your branch if that helps.
Thanks very much! I'll carry it in my tree.
-Kees
--
Kees Cook
prev parent reply other threads:[~2024-03-01 6:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202402240702.zJFNmahW-lkp@intel.com>
[not found] ` <202402231632.D90831AE51@keescook>
2024-02-27 7:35 ` [PATCH] objtool: Fix UNWIND_HINT_{SAVE,RESTORE} across basic blocks Josh Poimboeuf
2024-03-01 6:33 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202402292232.2D9E913F@keescook \
--to=keescook@chromium.org \
--cc=aleksander.lobakin@intel.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox