From: Stefan Berger <stefanb@linux.ibm.com>
To: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
herbert@gondor.apana.org.au, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br,
lukas@wunner.de, Stefan Berger <stefanb@linux.ibm.com>
Subject: [PATCH v4 00/12] Add support for NIST P521 to ecdsa
Date: Thu, 29 Feb 2024 21:19:55 -0500 [thread overview]
Message-ID: <20240301022007.344948-1-stefanb@linux.ibm.com> (raw)
This series adds support for the NIST P521 curve to the ecdsa module
to enable signature verification with it.
An issue with the current code in ecdsa is that it assumes that input
arrays providing key coordinates for example, are arrays of digits
(a 'digit' is a 'u64'). This works well for all currently supported
curves, such as NIST P192/256/384, but does not work for NIST P521 where
coordinates are 8 digits + 2 bytes long. So some of the changes deal with
converting byte arrays to digits and adjusting tests on input byte
array lengths to tolerate arrays not providing multiples of 8 bytes.
Regards,
Stefan
v4:
- Followed suggestions by Lukas Wummer (1,5,8/12)
- Use nbits rather than ndigits where needed (8/12)
- Renaming 'keylen' variablest to bufsize where necessary (9/12)
- Adjust signature size calculation for NIST P521 (11/12)
v3:
- Dropped ecdh support
- Use ecc_get_curve_nbits for getting number of bits in NIST P521 curve
in ecc_point_mult (7/10)
v2:
- Reformulated some patch descriptions
- Fixed issue detected by krobot
- Some other small changes to the code
Stefan Berger (12):
crypto: ecdsa - Convert byte arrays with key coordinates to digits
crypto: ecdsa - Adjust tests on length of key parameters
crypto: ecdsa - Extend res.x mod n calculation for NIST P521
crypto: ecc - Implement vli_mmod_fast_521 for NIST p521
crypto: ecc - Add nbits field to ecc_curve structure
crypto: ecc - Add special case for NIST P521 in ecc_point_mult
crypto: ecc - Add NIST P521 curve parameters
crypto: ecdsa - Replace ndigits with nbits where precision is needed
crypto: ecdsa - Rename keylen to bufsize where necessary
crypto: ecdsa - Register NIST P521 and extend test suite
crypto: asymmetric_keys - Adjust signature size calculation for NIST
P521
crypto: x509 - Add OID for NIST P521 and extend parser for it
crypto/asymmetric_keys/public_key.c | 14 ++-
crypto/asymmetric_keys/x509_cert_parser.c | 3 +
crypto/ecc.c | 38 +++++-
crypto/ecc_curve_defs.h | 49 ++++++++
crypto/ecdsa.c | 62 ++++++---
crypto/ecrdsa_defs.h | 5 +
crypto/testmgr.c | 7 ++
crypto/testmgr.h | 146 ++++++++++++++++++++++
include/crypto/ecc_curve.h | 3 +
include/crypto/ecdh.h | 1 +
include/crypto/internal/ecc.h | 27 +++-
include/linux/oid_registry.h | 1 +
12 files changed, 339 insertions(+), 17 deletions(-)
--
2.43.0
next reply other threads:[~2024-03-01 2:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 2:19 Stefan Berger [this message]
2024-03-01 2:19 ` [PATCH v4 01/12] crypto: ecdsa - Convert byte arrays with key coordinates to digits Stefan Berger
2024-03-01 20:36 ` Jarkko Sakkinen
2024-03-02 21:34 ` Lukas Wunner
2024-03-03 6:37 ` James Bottomley
2024-03-03 16:34 ` Stefan Berger
2024-03-01 2:19 ` [PATCH v4 02/12] crypto: ecdsa - Adjust tests on length of key parameters Stefan Berger
2024-03-01 2:19 ` [PATCH v4 03/12] crypto: ecdsa - Extend res.x mod n calculation for NIST P521 Stefan Berger
2024-03-01 2:19 ` [PATCH v4 04/12] crypto: ecc - Implement vli_mmod_fast_521 for NIST p521 Stefan Berger
2024-03-03 11:05 ` Lukas Wunner
2024-03-03 16:29 ` Stefan Berger
2024-03-01 2:20 ` [PATCH v4 05/12] crypto: ecc - Add nbits field to ecc_curve structure Stefan Berger
2024-03-03 11:07 ` Lukas Wunner
2024-03-03 16:32 ` Stefan Berger
2024-03-01 2:20 ` [PATCH v4 06/12] crypto: ecc - Add special case for NIST P521 in ecc_point_mult Stefan Berger
2024-03-01 2:20 ` [PATCH v4 07/12] crypto: ecc - Add NIST P521 curve parameters Stefan Berger
2024-03-01 2:20 ` [PATCH v4 08/12] crypto: ecdsa - Replace ndigits with nbits where precision is needed Stefan Berger
2024-03-01 2:20 ` [PATCH v4 09/12] crypto: ecdsa - Rename keylen to bufsize where necessary Stefan Berger
2024-03-01 20:41 ` Jarkko Sakkinen
2024-03-01 20:47 ` Stefan Berger
2024-03-01 20:50 ` Jarkko Sakkinen
2024-03-01 21:20 ` Stefan Berger
2024-03-01 2:20 ` [PATCH v4 10/12] crypto: ecdsa - Register NIST P521 and extend test suite Stefan Berger
2024-03-01 2:20 ` [PATCH v4 11/12] crypto: asymmetric_keys - Adjust signature size calculation for NIST P521 Stefan Berger
2024-03-03 18:47 ` Lukas Wunner
2024-03-03 21:03 ` Stefan Berger
2024-03-01 2:20 ` [PATCH v4 12/12] crypto: x509 - Add OID for NIST P521 and extend parser for it Stefan Berger
2024-03-04 18:10 ` [PATCH v4 00/12] Add support for NIST P521 to ecdsa Lukas Wunner
2024-03-04 19:01 ` Stefan Berger
-- strict thread matches above, loose matches on Subject: below --
2024-03-06 22:22 Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301022007.344948-1-stefanb@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=saulo.alessandre@tse.jus.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox