Re: [PATCH v4 05/12] crypto: ecc - Add nbits field to ecc_curve structure

Lukas Wunner
2024-03-03T11:07:13Z

On Thu, Feb 29, 2024 at 09:20:00PM -0500, Stefan Berger wrote:
> Add the number of bits a curve has to the ecc_curve definition and set it
> on all cruve definitions.

Nit: s/cruve/curve/

> --- a/include/crypto/ecc_curve.h
> +++ b/include/crypto/ecc_curve.h
> @@ -23,6 +23,8 @@ struct ecc_point {
> * struct ecc_curve - definition of elliptic curve
> *
> * @name: Short name of the curve.
> + * @nbits: Curves that do not use all bits in their ndigits must specify
> + * their number of bits here, otherwise can leave at 0.
> * @g: Generator point of the curve.
> * @p: Prime number, if Barrett's reduction is used for this curve
> * pre-calculated value 'mu' is appended to the @p after ndigits.

Nit: Looks like this kernel-doc uses 1 tab instead of blanks.