public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.ibm.com>
To: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
	herbert@gondor.apana.org.au, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br,
	lukas@wunner.de, Stefan Berger <stefanb@linux.ibm.com>
Subject: [PATCH v4 04/12] crypto: ecc - Implement vli_mmod_fast_521 for NIST p521
Date: Thu, 29 Feb 2024 21:19:59 -0500	[thread overview]
Message-ID: <20240301022007.344948-5-stefanb@linux.ibm.com> (raw)
In-Reply-To: <20240301022007.344948-1-stefanb@linux.ibm.com>

Implement vli_mmod_fast_521 following the description for how to calculate
the modulus for NIST P521 in the NIST publication "Recommendations for
Discrete Logarithm-Based Cryptography: Elliptic Curve Domain Parameters"
section G.1.4.

NIST p521 requires 9 64bit digits, so increase the ECC_MAX_DIGITS so that
arrays fit the larger numbers.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
 crypto/ecc.c                  | 31 +++++++++++++++++++++++++++++++
 include/crypto/internal/ecc.h |  2 +-
 2 files changed, 32 insertions(+), 1 deletion(-)

diff --git a/crypto/ecc.c b/crypto/ecc.c
index f53fb4d6af99..ea7b28b5e00e 100644
--- a/crypto/ecc.c
+++ b/crypto/ecc.c
@@ -902,6 +902,31 @@ static void vli_mmod_fast_384(u64 *result, const u64 *product,
 #undef AND64H
 #undef AND64L
 
+/* Computes result = product % curve_prime
+ * from "Recommendations for Discrete Logarithm-Based Cryptography:
+ *       Elliptic Curve Domain Parameters" G.1.4
+ */
+static void vli_mmod_fast_521(u64 *result, const u64 *product,
+				const u64 *curve_prime, u64 *tmp)
+{
+	const unsigned int ndigits = 9;
+	size_t i;
+
+	for (i = 0; i < ndigits; i++)
+		tmp[i] = product[i];
+	tmp[8] &= 0x1ff;
+
+	vli_set(result, tmp, ndigits);
+
+
+	for (i = 0; i < ndigits; i++)
+		tmp[i] = (product[8 + i] >> 9) | (product[9 + i] << 55);
+	tmp[8] &= 0x1ff;
+
+	vli_mod_add(result, result, tmp, curve_prime, ndigits);
+}
+
+
 /* Computes result = product % curve_prime for different curve_primes.
  *
  * Note that curve_primes are distinguished just by heuristic check and
@@ -941,6 +966,12 @@ static bool vli_mmod_fast(u64 *result, u64 *product,
 	case 6:
 		vli_mmod_fast_384(result, product, curve_prime, tmp);
 		break;
+	case 9:
+		if (!strcmp(curve->name, "nist_521")) {
+			vli_mmod_fast_521(result, product, curve_prime, tmp);
+			break;
+		}
+		fallthrough;
 	default:
 		pr_err_ratelimited("ecc: unsupported digits size!\n");
 		return false;
diff --git a/include/crypto/internal/ecc.h b/include/crypto/internal/ecc.h
index 48a04605da7f..b63238b12204 100644
--- a/include/crypto/internal/ecc.h
+++ b/include/crypto/internal/ecc.h
@@ -33,7 +33,7 @@
 #define ECC_CURVE_NIST_P192_DIGITS  3
 #define ECC_CURVE_NIST_P256_DIGITS  4
 #define ECC_CURVE_NIST_P384_DIGITS  6
-#define ECC_MAX_DIGITS              (512 / 64) /* due to ecrdsa */
+#define ECC_MAX_DIGITS              (576 / 64) /* due to NIST P521 */
 
 #define ECC_DIGITS_TO_BYTES_SHIFT 3
 
-- 
2.43.0


  parent reply	other threads:[~2024-03-01  2:20 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01  2:19 [PATCH v4 00/12] Add support for NIST P521 to ecdsa Stefan Berger
2024-03-01  2:19 ` [PATCH v4 01/12] crypto: ecdsa - Convert byte arrays with key coordinates to digits Stefan Berger
2024-03-01 20:36   ` Jarkko Sakkinen
2024-03-02 21:34   ` Lukas Wunner
2024-03-03  6:37     ` James Bottomley
2024-03-03 16:34     ` Stefan Berger
2024-03-01  2:19 ` [PATCH v4 02/12] crypto: ecdsa - Adjust tests on length of key parameters Stefan Berger
2024-03-01  2:19 ` [PATCH v4 03/12] crypto: ecdsa - Extend res.x mod n calculation for NIST P521 Stefan Berger
2024-03-01  2:19 ` Stefan Berger [this message]
2024-03-03 11:05   ` [PATCH v4 04/12] crypto: ecc - Implement vli_mmod_fast_521 for NIST p521 Lukas Wunner
2024-03-03 16:29     ` Stefan Berger
2024-03-01  2:20 ` [PATCH v4 05/12] crypto: ecc - Add nbits field to ecc_curve structure Stefan Berger
2024-03-03 11:07   ` Lukas Wunner
2024-03-03 16:32     ` Stefan Berger
2024-03-01  2:20 ` [PATCH v4 06/12] crypto: ecc - Add special case for NIST P521 in ecc_point_mult Stefan Berger
2024-03-01  2:20 ` [PATCH v4 07/12] crypto: ecc - Add NIST P521 curve parameters Stefan Berger
2024-03-01  2:20 ` [PATCH v4 08/12] crypto: ecdsa - Replace ndigits with nbits where precision is needed Stefan Berger
2024-03-01  2:20 ` [PATCH v4 09/12] crypto: ecdsa - Rename keylen to bufsize where necessary Stefan Berger
2024-03-01 20:41   ` Jarkko Sakkinen
2024-03-01 20:47     ` Stefan Berger
2024-03-01 20:50       ` Jarkko Sakkinen
2024-03-01 21:20         ` Stefan Berger
2024-03-01  2:20 ` [PATCH v4 10/12] crypto: ecdsa - Register NIST P521 and extend test suite Stefan Berger
2024-03-01  2:20 ` [PATCH v4 11/12] crypto: asymmetric_keys - Adjust signature size calculation for NIST P521 Stefan Berger
2024-03-03 18:47   ` Lukas Wunner
2024-03-03 21:03     ` Stefan Berger
2024-03-01  2:20 ` [PATCH v4 12/12] crypto: x509 - Add OID for NIST P521 and extend parser for it Stefan Berger
2024-03-04 18:10 ` [PATCH v4 00/12] Add support for NIST P521 to ecdsa Lukas Wunner
2024-03-04 19:01   ` Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240301022007.344948-5-stefanb@linux.ibm.com \
    --to=stefanb@linux.ibm.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=saulo.alessandre@tse.jus.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox