From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A9F45FBBF for ; Fri, 1 Mar 2024 06:30:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709274621; cv=none; b=OxYiO+qTZ37xxSo3J4RwDbvlIsReNdq4fa7c40lD1n9r8aBW1iL13UtRacBhfou2PtKa/XcP59vTaAJRhozIRPjyugmW6lH1Ek/Ay/sJup+uEB4IZGLjv3si3msjFvz4IWfAkfZenGwssV/EebtkqIrcR40VUm8u4ARu91qiVME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709274621; c=relaxed/simple; bh=yQbUQsOdFYQQXWH7Fu3bQwR+ZertHCl0TbbU2bMrM9I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ufdQETrDAEHT/vrAcAojYIiEk7feRnKX7LKVHGPNyj9H2j7a7KDv+kimVzjXZShzQCT8ybqVt1vLCfSuFCvI95YZzUgnjhDtWBwiNzmQR80o6A66bCsPqntSyvKe/6NXkTRgo4jECM2F26cGKNpS89pLlIMjs7eBlgf7CHBlfBU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=sjuvuVk3; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="sjuvuVk3" Received: from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi [89.27.53.110]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B21AD15EE; Fri, 1 Mar 2024 07:30:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1709274603; bh=yQbUQsOdFYQQXWH7Fu3bQwR+ZertHCl0TbbU2bMrM9I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sjuvuVk3mvhPD4qOQdsUfQL9rsF7Ebg/5dWQ0amqTckNifDDjFNTOQRMzgM3usEBu /py7bYR1hX+q7b0FmLKseEmEHuUoiAxuU6Eypnw6UXw0yQk6hiBSEOqggJocR7sJgB +8aPDIfsBp3wgLtdNcPC7z1VReju+5hs4I/6PfLg= Date: Fri, 1 Mar 2024 08:30:20 +0200 From: Laurent Pinchart To: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , Jagan Teki , Marek Vasut , Adrien Grassein , Srinivas Kandagatla , Sam Ravnborg , Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Vinay Simha BN , Christopher Vollo , Jessica Zhang , Marijn Suijten , AngeloGioacchino Del Regno , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno Subject: Re: [PATCH v2 9/9] drm/panel: truly-nt35597: Don't log an error when DSI host can't be found Message-ID: <20240301063020.GL30889@pendragon.ideasonboard.com> References: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> <20240229-anx7625-defer-log-no-dsi-host-v2-9-00506941049a@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240229-anx7625-defer-log-no-dsi-host-v2-9-00506941049a@collabora.com> Hi Nícolas, Thank you for the patch. On Thu, Feb 29, 2024 at 07:12:15PM -0500, Nícolas F. R. A. Prado wrote: > Given that failing to find a DSI host causes the driver to defer probe, > make use of dev_err_probe() to log the reason. This makes the defer > probe reason available and avoids alerting userspace about something > that is not necessarily an error. > > Suggested-by: AngeloGioacchino Del Regno > Signed-off-by: Nícolas F. R. A. Prado > --- > drivers/gpu/drm/panel/panel-truly-nt35597.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-truly-nt35597.c b/drivers/gpu/drm/panel/panel-truly-nt35597.c > index b73448cf349d..d447db912a61 100644 > --- a/drivers/gpu/drm/panel/panel-truly-nt35597.c > +++ b/drivers/gpu/drm/panel/panel-truly-nt35597.c > @@ -550,10 +550,8 @@ static int truly_nt35597_probe(struct mipi_dsi_device *dsi) > > dsi1_host = of_find_mipi_dsi_host_by_node(dsi1); > of_node_put(dsi1); > - if (!dsi1_host) { > - dev_err(dev, "failed to find dsi host\n"); > - return -EPROBE_DEFER; > - } > + if (!dsi1_host) > + return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); With this addressed, Reviewed-by: Laurent Pinchart > > /* register the second DSI device */ > dsi1_device = mipi_dsi_device_register_full(dsi1_host, &info); > -- Regards, Laurent Pinchart