From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 850A248CDC for ; Fri, 1 Mar 2024 08:56:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709283387; cv=none; b=XpKrUxWCOFULWtkWKnScezCxBx4P3t7qOJsm5FbpT/2xQCR95FxNqziAhfmoWa2SClcRJfXkIgFWdZJyhNSf1gUtom10CAMCL3eq0ophkSyDaUkEkzB4SXGYgy4E6naiECEZVbhS8T9FOkZlAThSY9xMHphX4O/csDBUh70s8zI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709283387; c=relaxed/simple; bh=oSSbSpGB1xGIeGf4XwN8CfSvxw/vvGIdP+EG9LG6jng=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iVLHn71eq2lm0zrTLLLuXkKJZFJB/RYiQNsSdblDeSep2usJO6DQ9N+eqF2k2D+QygOOfnpWES2pGsCz6sNU81KWNg24xLh6QItotlDLiaHjuT6hhzT9z0DvjFHAvRukuX8KhzID5vBnnBRn3mC+eXO47++R8+e4G2cn03Q2VsE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=Y1zaEErm; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Y1zaEErm" Received: from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi [89.27.53.110]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E7D5E899; Fri, 1 Mar 2024 09:56:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1709283368; bh=oSSbSpGB1xGIeGf4XwN8CfSvxw/vvGIdP+EG9LG6jng=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y1zaEErmORD6wTqO2hNh9AYi/oh6ybgGBjMz5svTlX8FG6Uqp5LcKLyFAhp2Gfl8B /Xv2yw8m2+WmKkzTzheOZndhF+KnEbKj7u83YZc+SqWtYA9/btpamz94HY4zmcLSAa HLACKk3Z3tWWzCvk2JwSx1txs0ZvBlmLJ7G32i7k= Date: Fri, 1 Mar 2024 10:56:24 +0200 From: Laurent Pinchart To: AngeloGioacchino Del Regno Cc: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , Jagan Teki , Marek Vasut , Adrien Grassein , Srinivas Kandagatla , Sam Ravnborg , Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Vinay Simha BN , Christopher Vollo , Jessica Zhang , Marijn Suijten , AngeloGioacchino Del Regno , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 9/9] drm/panel: truly-nt35597: Don't log an error when DSI host can't be found Message-ID: <20240301085624.GC30104@pendragon.ideasonboard.com> References: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> <20240229-anx7625-defer-log-no-dsi-host-v2-9-00506941049a@collabora.com> <20240301063020.GL30889@pendragon.ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Mar 01, 2024 at 09:44:36AM +0100, AngeloGioacchino Del Regno wrote: > Il 01/03/24 07:30, Laurent Pinchart ha scritto: > > On Thu, Feb 29, 2024 at 07:12:15PM -0500, Nícolas F. R. A. Prado wrote: > >> Given that failing to find a DSI host causes the driver to defer probe, > >> make use of dev_err_probe() to log the reason. This makes the defer > >> probe reason available and avoids alerting userspace about something > >> that is not necessarily an error. > >> > >> Suggested-by: AngeloGioacchino Del Regno > >> Signed-off-by: Nícolas F. R. A. Prado > >> --- > >> drivers/gpu/drm/panel/panel-truly-nt35597.c | 6 ++---- > >> 1 file changed, 2 insertions(+), 4 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/panel/panel-truly-nt35597.c b/drivers/gpu/drm/panel/panel-truly-nt35597.c > >> index b73448cf349d..d447db912a61 100644 > >> --- a/drivers/gpu/drm/panel/panel-truly-nt35597.c > >> +++ b/drivers/gpu/drm/panel/panel-truly-nt35597.c > >> @@ -550,10 +550,8 @@ static int truly_nt35597_probe(struct mipi_dsi_device *dsi) > >> > >> dsi1_host = of_find_mipi_dsi_host_by_node(dsi1); > >> of_node_put(dsi1); > >> - if (!dsi1_host) { > >> - dev_err(dev, "failed to find dsi host\n"); > >> - return -EPROBE_DEFER; > >> - } > >> + if (!dsi1_host) > >> + return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); > > > > return dev_err_probe(dev, -EPROBE_DEFER, > > "failed to find dsi host\n"); > > > > With this addressed, > > I disagree. That's 87 columns, and the 80-col rule is long gone. It's still a maintainer's preference. I soft-enforce it in drivers I maintain. In this case I'll let Neil decide, as he's listed as the maintainer for drivers/gpu/drm/panel/. > Reviewed-by: AngeloGioacchino Del Regno > > > Reviewed-by: Laurent Pinchart > > > >> > >> /* register the second DSI device */ > >> dsi1_device = mipi_dsi_device_register_full(dsi1_host, &info); -- Regards, Laurent Pinchart