public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>,
	keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br
Subject: Re: [PATCH v3 01/10] crypto: ecdsa - Convert byte arrays with key coordinates to digits
Date: Sat, 2 Mar 2024 22:36:09 +0100	[thread overview]
Message-ID: <20240302213609.GB30938@wunner.de> (raw)
In-Reply-To: <f5dacc38-bf53-4dc7-95cf-54b8b13dd1d7@linux.ibm.com>

On Sat, Mar 02, 2024 at 04:19:49PM -0500, Stefan Berger wrote:
> On 3/2/24 09:00, Lukas Wunner wrote:
> > Maybe eliminate the for-loop as well?
> > 
> > 	unsigned int o = nbytes & 7;
> > 	u64 msd = 0;
> > 
> > 	if (o != 0) {
> > 		/* if key length is not a multiple of 64 bits (NIST P521) */
> > 		memcpy((u8 *)&msd + sizeof(msd) - o, in, o);
> > 		out[--ndigits] = be64_to_cpu(msd);
> > 		in += o;
> > 	}
> > 
> > 	ecc_swap_digits(in, out, ndigits);
> 
> Will take this for v5 with your Suggested-by:, ok?

Sure, feel free to, but better test it because I haven't. :-)

I'll look through the rest of the series tomorrow. %-)

Thanks,

Lukas

  reply	other threads:[~2024-03-02 21:36 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 20:41 [PATCH v3 00/10] Add support for NIST P521 to ecdsa Stefan Berger
2024-02-23 20:41 ` [PATCH v3 01/10] crypto: ecdsa - Convert byte arrays with key coordinates to digits Stefan Berger
2024-02-29  9:11   ` Lukas Wunner
2024-02-29 14:57     ` Stefan Berger
2024-02-29 16:48       ` Lukas Wunner
2024-02-29 17:20         ` Stefan Berger
2024-03-01 20:26       ` Jarkko Sakkinen
2024-03-01 20:48         ` Stefan Berger
2024-03-01 20:51           ` Jarkko Sakkinen
2024-03-02 14:00         ` Lukas Wunner
2024-03-02 21:19           ` Stefan Berger
2024-03-02 21:36             ` Lukas Wunner [this message]
2024-03-02 21:55           ` Jarkko Sakkinen
2024-02-23 20:41 ` [PATCH v3 02/10] crypto: ecdsa - Adjust tests on length of key parameters Stefan Berger
2024-02-29  9:16   ` Lukas Wunner
2024-02-29 20:28     ` Stefan Berger
2024-02-23 20:41 ` [PATCH v3 03/10] crypto: ecdsa - Extend res.x mod n calculation for NIST P521 Stefan Berger
2024-02-23 20:41 ` [PATCH v3 04/10] crypto: ecc - Implement vli_mmod_fast_521 for NIST p521 Stefan Berger
2024-02-23 20:41 ` [PATCH v3 05/10] crypto: ecc - Add nbits field to ecc_curve structure Stefan Berger
2024-02-23 20:41 ` [PATCH v3 06/10] crypte: ecc - Implement ecc_curve_get_nbits to get number of bits Stefan Berger
2024-02-27 20:15   ` Lukas Wunner
2024-02-29 20:29     ` Stefan Berger
2024-02-23 20:41 ` [PATCH v3 07/10] crypto: ecc - Use ecc_get_curve_nbits to get number of bits for NIST P521 Stefan Berger
2024-02-23 20:41 ` [PATCH v3 08/10] crypto: ecc - Add NIST P521 curve parameters Stefan Berger
2024-02-23 20:41 ` [PATCH v3 09/10] crypto: ecdsa - Register NIST P521 and extend test suite Stefan Berger
2024-02-23 20:41 ` [PATCH v3 10/10] x509: Add OID for NIST P521 and extend parser for it Stefan Berger
2024-02-29  9:34 ` [PATCH v3 00/10] Add support for NIST P521 to ecdsa Lukas Wunner
2024-02-29 18:45   ` Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240302213609.GB30938@wunner.de \
    --to=lukas@wunner.de \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=jarkko@kernel.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saulo.alessandre@tse.jus.br \
    --cc=stefanb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox