From: Greg KH <gregkh@linuxfoundation.org>
To: Aman Sharma <210100011@iitb.ac.in>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: pi433: Updated bitrate range from datasheet
Date: Sun, 3 Mar 2024 22:33:06 +0100 [thread overview]
Message-ID: <2024030301-busily-composure-784e@gregkh> (raw)
In-Reply-To: <ddbd681a7504ae8b8fd4dc69270e804d@iitb.ac.in>
On Mon, Mar 04, 2024 at 02:28:02AM +0530, Aman Sharma wrote:
> From a0528708b209739f0d566401bdd428e215abf366 Mon Sep 17 00:00:00 2001
> From: Aman Sharma <amansharma612002@gmail.com>
> Date: Mon, 4 Mar 2024 00:44:06 +0530
> Subject: [PATCH] Staging: pi433: Updated bitrate range from datasheet
Why is this all here in the changelog? Also, please use
scripts/get_maintainer.pl, you have sent this to an obsolete email list.
>
> Updated bitrate range for FSK and OOK modulation from datasheet.
>
> Signed-off-by: Aman Sharma<amansharma6122002@gmail.com>
> ---
> drivers/staging/pi433/Documentation/pi433.txt | 6 ++++--
> drivers/staging/pi433/TODO | 1 -
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/pi433/Documentation/pi433.txt
> b/drivers/staging/pi433/Documentation/pi433.txt
> index 4a0d34b4ad37..9ce7282ef6f8 100644
> --- a/drivers/staging/pi433/Documentation/pi433.txt
> +++ b/drivers/staging/pi433/Documentation/pi433.txt
> @@ -78,7 +78,8 @@ rf params:
> Allowed values: 433050000...434790000
> bit_rate
> bit rate used for transmission.
> - Allowed values: #####
> + Allowed values (For FSK): 1200...320000
> + Allowed values (For OOK): 1200...32768
> dev_frequency
> frequency deviation in case of FSK.
> Allowed values: 600...500000
> @@ -169,7 +170,8 @@ rf params:
> Allowed values: 433050000...434790000
> bit_rate
> bit rate used for transmission.
> - Allowed values: #####
> + Allowed values (For FSK): 1200...320000
> + Allowed values (For OOK): 1200...32768
Where did these values come from? If you can explain that in the
changelog text when you resend a v2, that would be great.
thanks,
greg k-h
prev parent reply other threads:[~2024-03-03 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 20:58 [PATCH] Staging: pi433: Updated bitrate range from datasheet Aman Sharma
2024-03-03 21:33 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024030301-busily-composure-784e@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=210100011@iitb.ac.in \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox