From: Lukas Wunner <lukas@wunner.de>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
herbert@gondor.apana.org.au, davem@davemloft.net,
linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br
Subject: Re: [PATCH v4 05/12] crypto: ecc - Add nbits field to ecc_curve structure
Date: Sun, 3 Mar 2024 12:07:05 +0100 [thread overview]
Message-ID: <20240303110705.GB394@wunner.de> (raw)
In-Reply-To: <20240301022007.344948-6-stefanb@linux.ibm.com>
On Thu, Feb 29, 2024 at 09:20:00PM -0500, Stefan Berger wrote:
> Add the number of bits a curve has to the ecc_curve definition and set it
> on all cruve definitions.
Nit: s/cruve/curve/
> --- a/include/crypto/ecc_curve.h
> +++ b/include/crypto/ecc_curve.h
> @@ -23,6 +23,8 @@ struct ecc_point {
> * struct ecc_curve - definition of elliptic curve
> *
> * @name: Short name of the curve.
> + * @nbits: Curves that do not use all bits in their ndigits must specify
> + * their number of bits here, otherwise can leave at 0.
> * @g: Generator point of the curve.
> * @p: Prime number, if Barrett's reduction is used for this curve
> * pre-calculated value 'mu' is appended to the @p after ndigits.
Nit: Looks like this kernel-doc uses 1 tab instead of blanks.
next prev parent reply other threads:[~2024-03-03 11:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 2:19 [PATCH v4 00/12] Add support for NIST P521 to ecdsa Stefan Berger
2024-03-01 2:19 ` [PATCH v4 01/12] crypto: ecdsa - Convert byte arrays with key coordinates to digits Stefan Berger
2024-03-01 20:36 ` Jarkko Sakkinen
2024-03-02 21:34 ` Lukas Wunner
2024-03-03 6:37 ` James Bottomley
2024-03-03 16:34 ` Stefan Berger
2024-03-01 2:19 ` [PATCH v4 02/12] crypto: ecdsa - Adjust tests on length of key parameters Stefan Berger
2024-03-01 2:19 ` [PATCH v4 03/12] crypto: ecdsa - Extend res.x mod n calculation for NIST P521 Stefan Berger
2024-03-01 2:19 ` [PATCH v4 04/12] crypto: ecc - Implement vli_mmod_fast_521 for NIST p521 Stefan Berger
2024-03-03 11:05 ` Lukas Wunner
2024-03-03 16:29 ` Stefan Berger
2024-03-01 2:20 ` [PATCH v4 05/12] crypto: ecc - Add nbits field to ecc_curve structure Stefan Berger
2024-03-03 11:07 ` Lukas Wunner [this message]
2024-03-03 16:32 ` Stefan Berger
2024-03-01 2:20 ` [PATCH v4 06/12] crypto: ecc - Add special case for NIST P521 in ecc_point_mult Stefan Berger
2024-03-01 2:20 ` [PATCH v4 07/12] crypto: ecc - Add NIST P521 curve parameters Stefan Berger
2024-03-01 2:20 ` [PATCH v4 08/12] crypto: ecdsa - Replace ndigits with nbits where precision is needed Stefan Berger
2024-03-01 2:20 ` [PATCH v4 09/12] crypto: ecdsa - Rename keylen to bufsize where necessary Stefan Berger
2024-03-01 20:41 ` Jarkko Sakkinen
2024-03-01 20:47 ` Stefan Berger
2024-03-01 20:50 ` Jarkko Sakkinen
2024-03-01 21:20 ` Stefan Berger
2024-03-01 2:20 ` [PATCH v4 10/12] crypto: ecdsa - Register NIST P521 and extend test suite Stefan Berger
2024-03-01 2:20 ` [PATCH v4 11/12] crypto: asymmetric_keys - Adjust signature size calculation for NIST P521 Stefan Berger
2024-03-03 18:47 ` Lukas Wunner
2024-03-03 21:03 ` Stefan Berger
2024-03-01 2:20 ` [PATCH v4 12/12] crypto: x509 - Add OID for NIST P521 and extend parser for it Stefan Berger
2024-03-04 18:10 ` [PATCH v4 00/12] Add support for NIST P521 to ecdsa Lukas Wunner
2024-03-04 19:01 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240303110705.GB394@wunner.de \
--to=lukas@wunner.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saulo.alessandre@tse.jus.br \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox