From: Jonathan Bergh <bergh.jonathan@gmail.com>
To: mchehab@kernel.org
Cc: mcgrof@kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jonathan Bergh <bergh.jonathan@gmail.com>
Subject: [PATCH 1/9] staging: media: av7110: Fix formatting problem where trailing statements should be on a new line
Date: Sun, 3 Mar 2024 20:20:32 +0100 [thread overview]
Message-ID: <20240303192040.8116-2-bergh.jonathan@gmail.com> (raw)
In-Reply-To: <20240303192040.8116-1-bergh.jonathan@gmail.com>
This patch makes the following change:
* Ensures trailing statements are always on a new line as per kernel
code style guidelines
Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com>
---
drivers/staging/media/av7110/sp8870.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c
index abf5c72607b6..83685443976d 100644
--- a/drivers/staging/media/av7110/sp8870.c
+++ b/drivers/staging/media/av7110/sp8870.c
@@ -248,7 +248,8 @@ static int sp8870_set_frontend_parameters(struct dvb_frontend *fe)
// set tuner parameters
if (fe->ops.tuner_ops.set_params) {
fe->ops.tuner_ops.set_params(fe);
- if (fe->ops.i2c_gate_ctrl) fe->ops.i2c_gate_ctrl(fe, 0);
+ if (fe->ops.i2c_gate_ctrl)
+ fe->ops.i2c_gate_ctrl(fe, 0);
}
// sample rate correction bit [23..17]
@@ -296,7 +297,8 @@ static int sp8870_init (struct dvb_frontend* fe)
const struct firmware *fw = NULL;
sp8870_wake_up(state);
- if (state->initialised) return 0;
+ if (state->initialised)
+ return 0;
state->initialised = 1;
dprintk ("%s\n", __func__);
@@ -549,7 +551,8 @@ struct dvb_frontend* sp8870_attach(const struct sp8870_config* config,
/* allocate memory for the internal state */
state = kzalloc(sizeof(struct sp8870_state), GFP_KERNEL);
- if (state == NULL) goto error;
+ if (state == NULL)
+ goto error;
/* setup the state */
state->config = config;
@@ -557,7 +560,8 @@ struct dvb_frontend* sp8870_attach(const struct sp8870_config* config,
state->initialised = 0;
/* check if the demod is there */
- if (sp8870_readreg(state, 0x0200) < 0) goto error;
+ if (sp8870_readreg(state, 0x0200) < 0)
+ goto error;
/* create dvb_frontend */
memcpy(&state->frontend.ops, &sp8870_ops, sizeof(struct dvb_frontend_ops));
--
2.40.1
next prev parent reply other threads:[~2024-03-03 19:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 19:20 [PATCH 0/9] staging: media: av7110: These patches address various code style and formatting issues in the av7110 driver Jonathan Bergh
2024-03-03 19:20 ` Jonathan Bergh [this message]
2024-03-03 19:20 ` [PATCH 2/9] staging: media: av7110: Remove braces for single line statement blocks Jonathan Bergh
2024-03-03 19:20 ` [PATCH 3/9] staging: media: av7110: Remove spaces between function name and opening parenthesis Jonathan Bergh
2024-03-03 19:20 ` [PATCH 4/9] staging: media: av7110: Fix formatting of pointers to meet coding style guidelines Jonathan Bergh
2024-03-03 19:20 ` [PATCH 5/9] staging: media: av7110: Fix block comments to meet code " Jonathan Bergh
2024-03-03 19:20 ` [PATCH 6/9] staging: media: av7110: Remove extra whitespace before opening '['s Jonathan Bergh
2024-03-03 19:20 ` [PATCH 7/9] staging: media: av7110: Remove extra whitespace before ',' Jonathan Bergh
2024-03-03 19:20 ` [PATCH 8/9] staging: media: av7110: Ensure whitespace ahead of opening brace '{' Jonathan Bergh
2024-03-03 19:20 ` [PATCH 9/9] staging: media: av7110: Ensure newline after variable declarations Jonathan Bergh
2024-04-24 9:34 ` [PATCH 0/9] staging: media: av7110: These patches address various code style and formatting issues in the av7110 driver Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240303192040.8116-2-bergh.jonathan@gmail.com \
--to=bergh.jonathan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox