From: Kees Cook <keescook@chromium.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Mark Brown" <broonie@kernel.org>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2 2/3] spi: axi-spi-engine: use __counted_by() attribute
Date: Mon, 4 Mar 2024 09:36:23 -0800 [thread overview]
Message-ID: <202403040936.E933B96@keescook> (raw)
In-Reply-To: <20240304-mainline-axi-spi-engine-small-cleanups-v2-2-5b14ed729a31@baylibre.com>
On Mon, Mar 04, 2024 at 10:04:24AM -0600, David Lechner wrote:
> This adds the __counted_by() attribute to the flex array at the end of
> struct spi_engine_program in the AXI SPI Engine controller driver.
>
> The assignment of the length field has to be reordered to be before
> the access to the flex array in order to avoid potential compiler
> warnings/errors due to adding the __counted_by() attribute.
>
> Suggested-by: Nuno Sá <nuno.sa@analog.com>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Looks good! Thanks for the respin.
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2024-03-04 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 16:04 [PATCH v2 0/3] spi: axi-spi-engine: small cleanups David Lechner
2024-03-04 16:04 ` [PATCH v2 1/3] spi: axi-spi-engine: remove p from struct spi_engine_message_state David Lechner
2024-03-04 16:15 ` Gustavo A. R. Silva
2024-03-04 16:04 ` [PATCH v2 2/3] spi: axi-spi-engine: use __counted_by() attribute David Lechner
2024-03-04 16:16 ` Gustavo A. R. Silva
2024-03-04 17:36 ` Kees Cook [this message]
2024-03-04 16:04 ` [PATCH v2 3/3] spi: axi-spi-engine: use struct_size() macro David Lechner
2024-03-04 16:16 ` Gustavo A. R. Silva
2024-03-05 20:42 ` [PATCH v2 0/3] spi: axi-spi-engine: small cleanups Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202403040936.E933B96@keescook \
--to=keescook@chromium.org \
--cc=broonie@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gustavoars@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox