public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jonathan Bergh <bergh.jonathan@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH 2/2] staging: vme_user: Add a newline after variable declarations
Date: Tue, 5 Mar 2024 14:13:23 +0000	[thread overview]
Message-ID: <2024030549-sanding-finisher-dc6a@gregkh> (raw)
In-Reply-To: <20240303100547.153636-2-bergh.jonathan@gmail.com>

On Sun, Mar 03, 2024 at 11:05:47AM +0100, Jonathan Bergh wrote:
> This patch makes the following change:
>  * Adds a newline after the variable declarations as per checkpatch's
>    warning
> 
> Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com>
> ---
>  drivers/staging/vme_user/vme_tsi148.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
> index 2a92497c5570..a1b8288b101a 100644
> --- a/drivers/staging/vme_user/vme_tsi148.h
> +++ b/drivers/staging/vme_user/vme_tsi148.h
> @@ -34,6 +34,7 @@ struct tsi148_driver {
>  	void __iomem *base;	/* Base Address of device registers */
>  	wait_queue_head_t dma_queue[2];
>  	wait_queue_head_t iack_queue;
> +
>  	void (*lm_callback[4])(void *);	/* Called in interrupt handler */
>  	void *lm_data[4];
>  	void *crcsr_kernel;

Please always look at the change to see if checkpatch is correct or not
(hint, for this one, it is not.)  Also see the archives for many people
who have done the same thing in the past :)

thanks,

greg k-h

  reply	other threads:[~2024-03-05 14:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-03 10:05 [PATCH 1/2] staging: vme_user: Fix misaligned closing comment */ Jonathan Bergh
2024-03-03 10:05 ` [PATCH 2/2] staging: vme_user: Add a newline after variable declarations Jonathan Bergh
2024-03-05 14:13   ` Greg KH [this message]
2024-03-05 17:05     ` Jonathan Bergh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024030549-sanding-finisher-dc6a@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=bergh.jonathan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox