From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 0/3] spi: Add more consistency to CS handle
Date: Thu, 7 Mar 2024 17:00:58 +0200 [thread overview]
Message-ID: <20240307150256.3789138-1-andriy.shevchenko@linux.intel.com> (raw)
There are the following issues with the current code:
- inconsistent use of 0xFF and -1 for invalid chip select pin
- inconsistent plain or BIT() use with a hard-to-understand comment
- wrong types used for last_cs_* fields
Fix all of these here.
Andy Shevchenko (3):
spi: Consistently use BIT for cs_index_mask
spi: Fix types of the last chip select storage variables
spi: Introduce SPI_INVALID_CS and is_valid_cs()
drivers/spi/spi.c | 74 +++++++++++++++++++----------------------
include/linux/spi/spi.h | 12 +++----
2 files changed, 40 insertions(+), 46 deletions(-)
--
2.43.0.rc1.1.gbec44491f096
next reply other threads:[~2024-03-07 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 15:00 Andy Shevchenko [this message]
2024-03-07 15:00 ` [PATCH v1 1/3] spi: Consistently use BIT for cs_index_mask Andy Shevchenko
2024-03-07 15:01 ` [PATCH v1 2/3] spi: Fix types of the last chip select storage variables Andy Shevchenko
2024-03-07 15:01 ` [PATCH v1 3/3] spi: Introduce SPI_INVALID_CS and is_valid_cs() Andy Shevchenko
2024-03-07 17:56 ` [PATCH v1 0/3] spi: Add more consistency to CS handle Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307150256.3789138-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox