public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Mark Brown <broonie@kernel.org>, Michal Simek <michal.simek@amd.com>
Subject: [PATCH v1 3/3] spi: xilinx: Make num_chipselect 8-bit in the struct xspi_platform_data
Date: Thu,  7 Mar 2024 17:43:59 +0200	[thread overview]
Message-ID: <20240307154510.3795380-4-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20240307154510.3795380-1-andriy.shevchenko@linux.intel.com>

There is no use for whole 16-bit for the number of chip select pins.
Drop it to 8 bits and reshuffle the data structure layout to avoid
unnecessary paddings.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/linux/spi/xilinx_spi.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h
index 4ba8f53ce570..a638ba2a55bd 100644
--- a/include/linux/spi/xilinx_spi.h
+++ b/include/linux/spi/xilinx_spi.h
@@ -8,18 +8,18 @@ struct spi_board_info;
 
 /**
  * struct xspi_platform_data - Platform data of the Xilinx SPI driver
+ * @force_irq:		If set, forces QSPI transaction requirements.
  * @num_chipselect:	Number of chip select by the IP.
  * @bits_per_word:	Number of bits per word.
- * @devices:		Devices to add when the driver is probed.
  * @num_devices:	Number of devices in the devices array.
- * @force_irq:		If set, forces QSPI transaction requirements.
+ * @devices:		Devices to add when the driver is probed.
  */
 struct xspi_platform_data {
-	u16 num_chipselect;
-	u8 bits_per_word;
-	struct spi_board_info *devices;
-	u8 num_devices;
 	bool force_irq;
+	u8 num_chipselect;
+	u8 bits_per_word;
+	u8 num_devices;
+	struct spi_board_info *devices;
 };
 
 #endif /* __LINUX_SPI_XILINX_SPI_H */
-- 
2.43.0.rc1.1.gbec44491f096


  parent reply	other threads:[~2024-03-07 15:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07 15:43 [PATCH v1 0/3] spi: xilinx: Massage xilinx_spi.h Andy Shevchenko
2024-03-07 15:43 ` [PATCH v1 1/3] spi: xilinx: Fix kernel documentation in the xilinx_spi.h Andy Shevchenko
2024-03-08  8:22   ` Michal Simek
2024-03-07 15:43 ` [PATCH v1 2/3] spi: xilinx: Add necessary inclusion and forward declaration Andy Shevchenko
2024-03-08  8:21   ` Michal Simek
2024-03-08 13:56     ` Andy Shevchenko
2024-03-08 14:02       ` Michal Simek
2024-03-08 15:00         ` Andy Shevchenko
2024-03-08 15:27           ` Michal Simek
2024-03-07 15:43 ` Andy Shevchenko [this message]
2024-03-08  8:20   ` [PATCH v1 3/3] spi: xilinx: Make num_chipselect 8-bit in the struct xspi_platform_data Michal Simek
2024-03-08 13:31     ` Andy Shevchenko
2024-03-08 13:48       ` Michal Simek
2024-03-08 13:55         ` Andy Shevchenko
2024-03-08 14:00           ` Michal Simek
2024-03-08 15:01             ` Andy Shevchenko
2024-03-08 15:01               ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240307154510.3795380-4-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=michal.simek@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox