Re: [PATCH RFC 10/13] mm/gup: Merge pXd huge mapping checks

Jason Gunthorpe
2024-03-07T20:19:51Z

On Wed, Mar 06, 2024 at 06:41:44PM +0800, peterx@redhat.com wrote:
> From: Peter Xu <peterx@redhat.com>
>
> Huge mapping checks in GUP are slightly redundant and can be simplified.
>
> pXd_huge() now is the same as pXd_leaf(). pmd_trans_huge() and
> pXd_devmap() should both imply pXd_leaf(). Time to merge them into one.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> mm/gup.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)

Much better!

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason