From: "Michael Büsch" <m@bues.ch>
To: Rand Deeb <rand.sec96@gmail.com>
Cc: jonas.gorski@gmail.com, deeb.rand@confident.ru,
khoroshilov@ispras.ru, kvalo@kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
lvc-project@linuxtesting.org,
voskresenski.stanislav@confident.ru
Subject: Re: [PATCH v3] ssb: Fix potential NULL pointer dereference in ssb_device_uevent
Date: Thu, 7 Mar 2024 19:24:05 +0100 [thread overview]
Message-ID: <20240307192405.34aa9841@barney> (raw)
In-Reply-To: <20240307134142.169523-1-rand.sec96@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
On Thu, 7 Mar 2024 16:41:42 +0300
Rand Deeb <rand.sec96@gmail.com> wrote:
> Given that null is improbable in this context due to the calls being made
> through uevent, we should eliminate the redundant condition. In light of
> this, would you recommend sending a new version (v4)
No.
We should _not_ eliminate NULL checks in this code.
Ever.
There is only one reason to eliminate NULL checks:
In extremely performance critical code, if it improves performance
significantly and it is clearly documented that the pointer can never be NULL.
This is not that case here. This is not critical code.
Having NULL checks is defensive programming.
Removing NULL checks is a hazard.
Not having these checks is a big part of why security sucks in today's software.
V3 shall be applied, because it fixes a clear bug. Whether this bug can actually
be triggered or not in today's kernel doesn't matter.
--
Michael Büsch
https://bues.ch/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-03-07 18:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 12:30 [PATCH v3] ssb: Fix potential NULL pointer dereference in ssb_device_uevent Rand Deeb
2024-03-06 15:54 ` Jeff Johnson
2024-03-06 19:51 ` Jonas Gorski
2024-03-07 13:41 ` Rand Deeb
2024-03-07 18:24 ` Michael Büsch [this message]
2024-03-07 21:19 ` Rand Deeb
2024-03-07 21:38 ` Michael Büsch
2024-03-07 22:02 ` James Dutton
2024-03-08 4:50 ` Michael Büsch
2024-03-07 23:29 ` Rand Deeb
2024-03-08 1:04 ` James Dutton
2024-03-08 12:11 ` Rand Deeb
2024-03-08 5:09 ` Michael Büsch
2024-03-08 11:36 ` Rand Deeb
2024-03-08 15:44 ` Michael Büsch
2024-03-12 15:31 ` [v3] ssb: Fix potential NULL pointer dereference in ssb_device_uevent() Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307192405.34aa9841@barney \
--to=m@bues.ch \
--cc=deeb.rand@confident.ru \
--cc=jonas.gorski@gmail.com \
--cc=khoroshilov@ispras.ru \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=rand.sec96@gmail.com \
--cc=voskresenski.stanislav@confident.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox