From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7065713E7F4; Thu, 7 Mar 2024 22:25:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709850348; cv=none; b=kz2XL4e1lSIPuBgMIZBCYcxJLzuDufGz/OHGs8dHxllxysfZVHA+AtwpNYax1mhBLR1YHGdCJbcg6z6RHt/ThnhnTqNEPZUwnR60lrwKasoo3VQBg17uFTRCVfpHLSkMRqb0zPwVM8xuFgey166oNoj6zBARYVont/9cFyF2v2w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709850348; c=relaxed/simple; bh=TOXR+EDXAVd4J1XWgqy4st5avJH4c6BcdZwNi55Vyr4=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=BiArEPSW5OvezEOKwy8Grq1BODdHLU5+jMkczBYBcMcwRx9EjZoOSGEJCNfGYqQ1m1jlzQJsSwzF3dbyd6Ay+BVz08BmVWpLC7dMMuDz0nghLrSqMNQv8c0Y3xobn1AAZ5aAPbHpT/zkAqL3v/+cSC+WYTg641Y29vfAZOjwVMM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ccTGVKEM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ccTGVKEM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87CB7C433C7; Thu, 7 Mar 2024 22:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709850347; bh=TOXR+EDXAVd4J1XWgqy4st5avJH4c6BcdZwNi55Vyr4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ccTGVKEMPay0KoRXj5r8JTMwSPADQfp0xosy8gfOZAmLigE76OlZGlKJAb4QooJHf uUYll1ow3BHPFx0IQSSQdYH974FqLMwJPf/2fwcPRCQe74ef6uEcykyrAtwUBXqRH/ R893hlTWMmx+QCxwz/ynYkh/sA5D3pCVNE67YDvs9RhNBa52XtKqu10kC65SRCAI6n RxuhWZFn5AxGHY4gQjXenJQfpRumgFVGUz8VjGDZsdaZFSS0BUqnep43D27sX39VKx XxTGeGoadR17ZsVvSvwHvjUVYJ6OJkmv+nr9eKKL5FvUEXkcP3FTJmzRiOmjpiwa5n R3GIKxHtKaHDQ== Date: Thu, 7 Mar 2024 16:25:45 -0600 From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Mika Westerberg , "David E . Box" , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , "Rafael J . Wysocki" , Tasev Nikola , Mark Enriquez , Thomas Witt , Werner Sembach , Vidya Sagar , Kai-Heng Feng , Kuppuswamy Sathyanarayanan , Ricky Wu , Mario Limonciello , Bjorn Helgaas , Koba Ko Subject: Re: [PATCH v7 0/5] PCI/ASPM: Save/restore L1 PM Substates for suspend/resume Message-ID: <20240307222545.GA655965@bhelgaas> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240305214656.GA550701@bhelgaas> [+cc Koba Ko] On Tue, Mar 05, 2024 at 03:46:56PM -0600, Bjorn Helgaas wrote: > On Fri, Feb 23, 2024 at 02:58:46PM -0600, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > This is some rework of David's series to preserve ASPM L1 substate > > configuration across suspend/resume. > > ... > > David E. Box (5): > > PCI/ASPM: Move pci_configure_ltr() to aspm.c > > PCI/ASPM: Always build aspm.c > > PCI/ASPM: Move pci_save_ltr_state() to aspm.c > > PCI/ASPM: Save L1 PM Substates Capability for suspend/resume > > PCI/ASPM: Call pci_save_ltr_state() from pci_save_pcie_state() > > > > drivers/pci/pci.c | 89 ++++------------ > > drivers/pci/pci.h | 13 ++- > > drivers/pci/pcie/Makefile | 2 +- > > drivers/pci/pcie/aspm.c | 215 ++++++++++++++++++++++++++++++++++++++ > > drivers/pci/probe.c | 62 +---------- > > include/linux/pci.h | 2 +- > > 6 files changed, 252 insertions(+), 131 deletions(-) > > I applied these as pci/aspm for v6.9, replacing the original unlabeled > v6 that has been in -next. Would anybody be able to test this, particularly to make sure it works for the bugs we're claiming to fix with this series? https://bugzilla.kernel.org/show_bug.cgi?id=217321 https://bugzilla.kernel.org/show_bug.cgi?id=216782 https://bugzilla.kernel.org/show_bug.cgi?id=216877 This series is headed for v6.9, and I hope we can finally claim victory over these issues. This is in -next as of the Mar 7 tree. Or if you want just the ASPM changes, based on v6.8-rc1, you can use the branch at https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/log/?h=aspm Bjorn