Re: [PATCH v2] binder: remove redundant variable page_addr

Greg Kroah-Hartman
2024-03-07T21:43:49Z

On Tue, Jan 16, 2024 at 07:32:34PM +0000, Carlos Llamas wrote:
> From: Colin Ian King <colin.i.king@intel.com>
>
> Variable page_addr is being assigned a value that is never read. The
> variable is redundant and can be removed.
>
> Cleans up clang scan build warning:
> warning: Value stored to 'page_addr' is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@intel.com>
> Fixes: 162c79731448 ("binder: avoid user addresses in debug logs")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202312060851.cudv98wG-lkp@intel.com/
> Acked-by: Carlos Llamas <cmllamas@google.com>
> ---
>
> Notes:
> v2: added tags, used char-misc-next as base
>
> drivers/android/binder_alloc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
> index a4a4dc87ba53..34d7a1494bc7 100644
> --- a/drivers/android/binder_alloc.c
> +++ b/drivers/android/binder_alloc.c
> @@ -925,7 +925,6 @@ void binder_alloc_deferred_release(struct binder_alloc *alloc)
> int i;
>
> for (i = 0; i < alloc->buffer_size / PAGE_SIZE; i++) {
> - unsigned long page_addr;
> bool on_lru;
>
> if (!alloc->pages[i].page_ptr)
> @@ -933,7 +932,6 @@ void binder_alloc_deferred_release(struct binder_alloc *alloc)
>
> on_lru = list_lru_del(&binder_freelist,
> &alloc->pages[i].lru);
> - page_addr = alloc->buffer + i * PAGE_SIZE;
> binder_alloc_debug(BINDER_DEBUG_BUFFER_ALLOC,
> "%s: %d: page %d %s\n",
> __func__, alloc->pid, i,
>
> base-commit: 5850edccec30325707f953bc088497b3b9041231
> --
> 2.43.0.275.g3460e3d667-goog
>

This doesn't apply to my tree anymore, can you rebase?

thanks,

greg k-h