From: Christoph Hellwig <hch@lst.de>
To: "brookxu.cn" <brookxu.cn@gmail.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] nvme: fix reconnection fail due to reserved tag allocation
Date: Fri, 8 Mar 2024 15:42:08 +0100 [thread overview]
Message-ID: <20240308144208.GA9194@lst.de> (raw)
In-Reply-To: <20240308015435.100968-1-brookxu.cn@gmail.com>
The fix looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But given that's we consolidate to a single place each for setting
up the tagsets for admin and I/O queues, what about just killing
the symbolic name and moving the assignments and comments directly
into the only users?
next prev parent reply other threads:[~2024-03-08 14:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 1:54 [PATCH v3] nvme: fix reconnection fail due to reserved tag allocation brookxu.cn
2024-03-08 14:42 ` Christoph Hellwig [this message]
2024-03-08 14:44 ` Sagi Grimberg
2024-03-08 16:29 ` 许春光
2024-03-08 16:31 ` Christoph Hellwig
2024-03-08 16:33 ` 许春光
2024-03-08 16:43 ` 许春光
2024-03-08 16:47 ` Keith Busch
2024-03-08 16:54 ` 许春光
2024-03-08 16:20 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240308144208.GA9194@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brookxu.cn@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox