Re: [PATCH net-next] IB/hfi1: allocate dummy net_device dynamically

Leon Romanovsky
2024-04-30T14:10:44Z

On Tue, Apr 30, 2024 at 10:03:49AM -0400, Dennis Dalessandro wrote:
> On 4/30/24 8:50 AM, Leon Romanovsky wrote:
> > On Fri, Apr 26, 2024 at 01:56:05AM -0700, Breno Leitao wrote:
> >> Embedding net_device into structures prohibits the usage of flexible
> >> arrays in the net_device structure. For more details, see the discussion
> >> at [1].
> >>
> >> Un-embed the net_device from struct hfi1_netdev_rx by converting it
> >> into a pointer. Then use the leverage alloc_netdev() to allocate the
> >> net_device object at hfi1_alloc_rx().
> >>
> >> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/
> >>
> >> Acked-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
> >> Signed-off-by: Breno Leitao <leitao@debian.org>
> >> ---
> >> Changelog
> >>
> >> v5:
> >> * Basically replaced the old alloc_netdev() by the new helper
> >> alloc_netdev_dummy().
> >> v4:
> >> * Fix the changelog format
> >> v3:
> >> * Re-worded the comment, by removing the first paragraph.
> >> v2:
> >> * Free struct hfi1_netdev_rx allocation if alloc_netdev() fails
> >> * Pass zero as the private size for alloc_netdev().
> >> * Remove wrong reference for iwl in the comments
> >> ---
> >>
> >> drivers/infiniband/hw/hfi1/netdev.h | 2 +-
> >> drivers/infiniband/hw/hfi1/netdev_rx.c | 9 +++++++--
> >> 2 files changed, 8 insertions(+), 3 deletions(-)
> >
> > Dennis,
> >
> > Do you plan to send anything to rdma-next which can potentially create
> > conflicts with netdev in this cycle?
> >
> > If not, it will be safe to apply this patch directly to net-next.
> >
> > Thanks
>
> Nothing right now. Should be safe to sent to net-next.

Jakub, can you please take this patch?

>
> FYI, since I talked about it publicly at the OFA Workshop recently. We will be
> starting the upstream of support for our new HW, soon.

Great, thanks

>
> -Denny