* [PATCH] riscv: Remove unused asm/signal.h file
@ 2024-03-10 11:21 Stafford Horne
2024-03-11 8:30 ` Guo Ren
0 siblings, 1 reply; 2+ messages in thread
From: Stafford Horne @ 2024-03-10 11:21 UTC (permalink / raw)
To: LKML
Cc: Stafford Horne, Paul Walmsley, Palmer Dabbelt, Albert Ou, Guo Ren,
Björn Töpel, linux-riscv
When riscv moved to common entry the definition and usage of
do_work_pending was removed. This unused header file remains.
Remove the header file as it is not used.
I have tested compiling the kernel with this patch applied and saw no
issues. Noticed when auditing how different ports handle signals
related to saving FPU state.
Fixes: f0bddf50586d ("riscv: entry: Convert to generic entry")
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
arch/riscv/include/asm/signal.h | 12 ------------
1 file changed, 12 deletions(-)
delete mode 100644 arch/riscv/include/asm/signal.h
diff --git a/arch/riscv/include/asm/signal.h b/arch/riscv/include/asm/signal.h
deleted file mode 100644
index 956ae0a01bad..000000000000
--- a/arch/riscv/include/asm/signal.h
+++ /dev/null
@@ -1,12 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#ifndef __ASM_SIGNAL_H
-#define __ASM_SIGNAL_H
-
-#include <uapi/asm/signal.h>
-#include <uapi/asm/ptrace.h>
-
-asmlinkage __visible
-void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags);
-
-#endif
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] riscv: Remove unused asm/signal.h file
2024-03-10 11:21 [PATCH] riscv: Remove unused asm/signal.h file Stafford Horne
@ 2024-03-11 8:30 ` Guo Ren
0 siblings, 0 replies; 2+ messages in thread
From: Guo Ren @ 2024-03-11 8:30 UTC (permalink / raw)
To: Stafford Horne
Cc: LKML, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Björn Töpel, linux-riscv
On Sun, Mar 10, 2024 at 7:21 PM Stafford Horne <shorne@gmail.com> wrote:
>
> When riscv moved to common entry the definition and usage of
> do_work_pending was removed. This unused header file remains.
>
> Remove the header file as it is not used.
>
> I have tested compiling the kernel with this patch applied and saw no
> issues. Noticed when auditing how different ports handle signals
> related to saving FPU state.
>
> Fixes: f0bddf50586d ("riscv: entry: Convert to generic entry")
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
> arch/riscv/include/asm/signal.h | 12 ------------
> 1 file changed, 12 deletions(-)
> delete mode 100644 arch/riscv/include/asm/signal.h
>
> diff --git a/arch/riscv/include/asm/signal.h b/arch/riscv/include/asm/signal.h
> deleted file mode 100644
> index 956ae0a01bad..000000000000
> --- a/arch/riscv/include/asm/signal.h
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-only */
> -
> -#ifndef __ASM_SIGNAL_H
> -#define __ASM_SIGNAL_H
> -
> -#include <uapi/asm/signal.h>
> -#include <uapi/asm/ptrace.h>
> -
> -asmlinkage __visible
> -void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags);
No more calling in arch/riscv for do_work_pending.
> -
> -#endif
> --
> 2.41.0
>
LGTM, Thx.
Reviewed-by: Guo Ren <guoren@kernel.org>
--
Best Regards
Guo Ren
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-11 8:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-10 11:21 [PATCH] riscv: Remove unused asm/signal.h file Stafford Horne
2024-03-11 8:30 ` Guo Ren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox