Re: [PATCH net-next 1/4] dt-bindings: net: dsa: realtek: describe LED usage

Krzysztof Kozlowski
2024-03-10T08:34:17Z

On 10/03/2024 05:51, Luiz Angelo Daros de Luca wrote:
> Each port can have up to 4 LEDs (3 for current rtl8365mb devices). The
> LED reg property will indicate its LED group.
>

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline), work on fork of kernel
(don't, instead use mainline) or you ignore some maintainers (really
don't). Just use b4 and everything should be fine, although remember
about `b4 prep --auto-to-cc` if you added new patches to the patchset.

> An example of LED usage was included in an existing switch example.
>
> Cc: devicetree@vger.kernel.org

Please drop the autogenerated scripts/get_maintainer.pl CC-entries from
commit msg. There is no single need to store automated output of
get_maintainers.pl in the git log. It can be easily re-created at any
given time, thus its presence in the git history is redundant and
obfuscates the log.

If you need it for your own patch management purposes, keep it under the
--- separator.

> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
> ---
> .../devicetree/bindings/net/dsa/realtek.yaml | 46 ++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> index 70b6bda3cf98..45c1656b3fae 100644
> --- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> @@ -108,6 +108,32 @@ properties:
> compatible:
> const: realtek,smi-mdio
>
> +patternProperties:
> + '^(ethernet-)?ports$':
> + type: object
> + additionalProperties: true
> +
> + patternProperties:
> + '^(ethernet-)?port@[0-6]$':
> + type: object
> + additionalProperties: true
> +
> + properties:
> + leds:

type: object
additionalProperties: false

> + description:
> + "LEDs associated with this port"

Drop quotes.

> +
> + patternProperties:
> + '^led@[a-f0-9]+$':

[0-3]

> + type: object
> + additionalProperties: true

This cannot be 'true'. Which then will point you to errors and missing
ref to leds schema and need to use unevaluatedProperties: false.

> +
> + properties:
> + reg:
> + description:
> + "reg indicates the LED group for this LED"

Drop quotes

Best regards,
Krzysztof