Re: [PATCH net-next 1/4] dt-bindings: net: dsa: realtek: describe LED usage

Krzysztof Kozlowski
2024-03-21T12:18:21Z

On 21/03/2024 12:56, Luiz Angelo Daros de Luca wrote:
>
>>
>>> +
>>> + patternProperties:
>>> + '^led@[a-f0-9]+$':
>>
>> [0-3]
>
> leds are already defined for a port. I'm just trying to add a
> restriction to allow only 0-3 leds and use that to identify the group.

Where is the restriction, in your original patch?

> These suggestions will redefine the leds property, forcing me to

How? I really do not see it.

> declare #address-cells, #size-cells for leds and reference the led
> schema in led@[0-3]. Is there a way to just add a constraint to what
> is already present?

I don't follow.

>
>>
>>> + type: object
>>> + additionalProperties: true
>>
>> This cannot be 'true'. Which then will point you to errors and missing
>> ref to leds schema and need to use unevaluatedProperties: false.
Best regards,
Krzysztof