Re: [PATCH] net: dsa: mt7530: disable LEDs before reset

Paolo Abeni
2024-03-12T10:46:14Z

On Tue, 2024-03-12 at 11:38 +0300, Arınç ÜNAL wrote:
> On 12.03.2024 00:10, patchwork-bot+netdevbpf@kernel.org wrote:
> > Hello:
> >
> > This patch was applied to netdev/net-next.git (main)
> > by Jakub Kicinski <kuba@kernel.org>:
> >
> > On Tue, 5 Mar 2024 06:39:51 +0200 you wrote:
> > > Disable LEDs just before resetting the MT7530 to avoid
> > > situations where the ESW_P4_LED_0 and ESW_P3_LED_0 pin
> > > states may cause an unintended external crystal frequency
> > > to be selected.
> > >
> > > The HT_XTAL_FSEL (External Crystal Frequency Selection)
> > > field of HWTRAP (the Hardware Trap register) stores a
> > > 2-bit value that represents the state of the ESW_P4_LED_0
> > > and ESW_P4_LED_0 pins (seemingly) sampled just after the
> > > MT7530 has been reset, as:
> > >
> > > [...]
> >
> > Here is the summary with links:
> > - net: dsa: mt7530: disable LEDs before reset
> > https://git.kernel.org/netdev/net-next/c/2920dd92b980
> >
> > You are awesome, thank you!
>
> I am once again calling for this patch to be reverted on the net-next tree
> on the basis of:
>
> - This patch did not go through a proper reviewing process. There are
> proposed changes on the code it changes regarding the scope and the
> method of the patch, and improvements to be made on the patch log.
>
> - This patch should be backported to stable releases, therefore it
> shouldn't be on the net-next tree and should be submitted to the net tree
> instead.

The net-next pull request is out:

https://lore.kernel.org/netdev/20240312042504.1835743-1-kuba@kernel.org/

at this point I believe we can't retract it unless there is a very
serious regression affecting most/all users. This does not look such
case.

I think the better option is follow-up on net with follow-up fixes if
any.

All the relevant patches could be sent to the stable tree later:

https://elixir.bootlin.com/linux/latest/source/Documentation/process/stable-kernel-rules.rst#L47

To try to reduce the possibilities of this kind of situation in the
future, may I kindly ask you to invest some more little time to help
the reviewers and the maintainers? e.g. trimming the replies explicitly
cutting all the unneeded parts in the quoted code/text would make the
whole conversation much easier to follow (at least to me). The netdev
volume is insane, it's very easy to get lost in a given thread and miss
relevant part of it.

Cheers,

Paolo