* [PATCH] media: dt-bindings: qcom,i2c-cci: Fix OV7251 'data-lanes' entries
@ 2024-03-11 22:26 Rob Herring
2024-03-14 7:06 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2024-03-11 22:26 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Loic Poulain, Robert Foss,
Andi Shyti, Krzysztof Kozlowski, Conor Dooley
Cc: linux-i2c, linux-arm-msm, devicetree, linux-kernel
The OV7251 sensor only has a single data lane, so 2 entries is not valid.
Fix this to be 1 entry as the schema specifies.
The schema validation doesn't catch this currently due to some limitations
in handling of arrays vs. matrices, but a fix is being worked on.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Of course, with only 1 lane, I'm not sure why we need data-lanes in the
first place?
---
Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
index 8386cfe21532..f0eabff86310 100644
--- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
+++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
@@ -270,7 +270,7 @@ examples:
port {
ov7251_ep: endpoint {
- data-lanes = <0 1>;
+ data-lanes = <0>;
link-frequencies = /bits/ 64 <240000000 319200000>;
remote-endpoint = <&csiphy3_ep>;
};
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: dt-bindings: qcom,i2c-cci: Fix OV7251 'data-lanes' entries
2024-03-11 22:26 [PATCH] media: dt-bindings: qcom,i2c-cci: Fix OV7251 'data-lanes' entries Rob Herring
@ 2024-03-14 7:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-14 7:06 UTC (permalink / raw)
To: Rob Herring, Bjorn Andersson, Konrad Dybcio, Loic Poulain,
Robert Foss, Andi Shyti, Krzysztof Kozlowski, Conor Dooley
Cc: linux-i2c, linux-arm-msm, devicetree, linux-kernel
On 11/03/2024 23:26, Rob Herring wrote:
> The OV7251 sensor only has a single data lane, so 2 entries is not valid.
> Fix this to be 1 entry as the schema specifies.
>
> The schema validation doesn't catch this currently due to some limitations
> in handling of arrays vs. matrices, but a fix is being worked on.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-14 7:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-11 22:26 [PATCH] media: dt-bindings: qcom,i2c-cci: Fix OV7251 'data-lanes' entries Rob Herring
2024-03-14 7:06 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox