From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74E26B657; Tue, 12 Mar 2024 07:57:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710230255; cv=none; b=Ji2lNjrOuLj2rb4OY5/Sy3hzgrfPzH58ajT5Bv3b+YG/eNrN6ct1kOJTELwm0lZM8umnYCTgUMbqMCjgsi7ySq9DNKbamPGt+NaeFKax5DcSgaz3RkU2oEc+HVsOw6KC+CoPf2KIBycSJfcnL0rCG3+dELUoNSORzhbUYEuKFLw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710230255; c=relaxed/simple; bh=VG3pR068UJKv/7BHxkzXJWO/gG7U9/48TQUtXnKKh4w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=da0hAO2gBvwI2GBZPRIBbYWGXWhwa4ixUeNbZHKOSpFrVQwXEh1PTDgTW/HbPGYVJmCnR2GGG1N3pgJuMlRW+R/3xJiXm3oLjiTlPb7OW3zkwIkFRiCecPQo33aSjqgzzlL0PRSQL8q34KKwCHQnXGvJ2l7hTkCZJqiLKVNU6ss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=O6AIzRjj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O6AIzRjj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48329C433C7; Tue, 12 Mar 2024 07:57:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710230254; bh=VG3pR068UJKv/7BHxkzXJWO/gG7U9/48TQUtXnKKh4w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O6AIzRjjYU9p2QdasGPWZZG7sFgY57p92Rp4xQhMxfvo9XvYQfFW+qrvMvQr/U0Qy OymTnmlEuAlvYqzBltq+aC8sFvuCuTfwhKna2ljxQq90sqzx7pULbG+qdsf0vnOuCf WGitSaCK/f/h+pTFXCvrLqd2XW9FuktDaX8f37JlXeQTMSWsnXX7MaztYH6VUUF40F 27ljsJAT72yNi2cAufQkMYKUm5FFOc45i6N9duf0WwydrTiky6r3MeHB8eMXlA9bMU ZuzeJBtpYxZUkN5pyOI41GlDJTqDtyNcbAYjegkwWL63rQQxz5I7RTlfl6YNB0TzTN 7Kw5ICwHKgnLQ== Date: Tue, 12 Mar 2024 09:57:30 +0200 From: Leon Romanovsky To: linke li Cc: bmt@zurich.ibm.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH] RDMA/siw: Reuse value read using READ_ONCE instead of re-reading it Message-ID: <20240312075730.GN12921@unreal> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Mar 12, 2024 at 09:30:53AM +0800, linke li wrote: > Thank you for your reasonal reply. That makes sense. But you may still > consider to make it better, like this patch, to read the flag only one > time. It will avoid some potential risks. However, it depends on > maintainer's choice. Maintainer doesn't see any potential risks and value is read only once anyway. Thanks > > Linke > Thanks > >