From: "Marek Behún" <kabel@kernel.org>
To: George Stark <gnstark@salutedevices.com>
Cc: <andy.shevchenko@gmail.com>, <pavel@ucw.cz>, <lee@kernel.org>,
<vadimp@nvidia.com>, <mpe@ellerman.id.au>, <npiggin@gmail.com>,
<christophe.leroy@csgroup.eu>, <hdegoede@redhat.com>,
<mazziesaccount@gmail.com>, <peterz@infradead.org>,
<mingo@redhat.com>, <will@kernel.org>, <longman@redhat.com>,
<boqun.feng@gmail.com>, <nikitos.tr@gmail.com>,
<kabel@kernel.org>, <linux-leds@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
<kernel@salutedevices.com>
Subject: Re: [PATCH v6 1/9] locking/mutex: introduce devm_mutex_init
Date: Thu, 14 Mar 2024 11:40:25 +0100 [thread overview]
Message-ID: <20240314114025.1e27399e@thinkpad> (raw)
In-Reply-To: <20240314084531.1935545-2-gnstark@salutedevices.com>
On Thu, 14 Mar 2024 11:45:23 +0300
George Stark <gnstark@salutedevices.com> wrote:
> Using of devm API leads to a certain order of releasing resources.
> So all dependent resources which are not devm-wrapped should be deleted
> with respect to devm-release order. Mutex is one of such objects that
> often is bound to other resources and has no own devm wrapping.
> Since mutex_destroy() actually does nothing in non-debug builds
> frequently calling mutex_destroy() is just ignored which is safe for now
> but wrong formally and can lead to a problem if mutex_destroy() will be
> extended so introduce devm_mutex_init()
>
> Signed-off-by: George Stark <gnstark@salutedevices.com>
> Suggested by-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Marek Behún <kabel@kernel.org>
next prev parent reply other threads:[~2024-03-14 10:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 8:45 [PATCH v6 0/9] devm_led_classdev_register() usage problem George Stark
2024-03-14 8:45 ` [PATCH v6 1/9] locking/mutex: introduce devm_mutex_init George Stark
2024-03-14 9:02 ` Christophe Leroy
2024-03-14 10:33 ` Andy Shevchenko
2024-03-14 10:40 ` Marek Behún [this message]
2024-03-14 13:32 ` Waiman Long
2024-03-14 8:45 ` [PATCH v6 2/9] leds: aw2013: use devm API to cleanup module's resources George Stark
2024-03-14 8:45 ` [PATCH v6 3/9] leds: aw200xx: " George Stark
2024-03-14 8:45 ` [PATCH v6 4/9] leds: lp3952: " George Stark
2024-03-14 8:45 ` [PATCH v6 5/9] leds: lm3532: " George Stark
2024-03-14 8:45 ` [PATCH v6 6/9] leds: nic78bx: " George Stark
2024-03-14 8:45 ` [PATCH v6 7/9] leds: mlxreg: use devm_mutex_init for mutex initializtion George Stark
2024-03-14 8:45 ` [PATCH v6 8/9] leds: an30259a: use devm_mutext_init for mutext initialization George Stark
2024-03-14 8:45 ` [PATCH v6 9/9] leds: powernv: use LED_RETAIN_AT_SHUTDOWN flag for leds George Stark
2024-03-14 10:34 ` Andy Shevchenko
2024-03-14 10:37 ` [PATCH v6 0/9] devm_led_classdev_register() usage problem Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240314114025.1e27399e@thinkpad \
--to=kabel@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=gnstark@salutedevices.com \
--cc=hdegoede@redhat.com \
--cc=kernel@salutedevices.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=longman@redhat.com \
--cc=mazziesaccount@gmail.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=nikitos.tr@gmail.com \
--cc=npiggin@gmail.com \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=vadimp@nvidia.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox