Re: [PATCH v3 1/2] media: dt-bindings: media: Add bindings for IMX283

Laurent Pinchart
2024-03-13T21:21:43Z

On Wed, Mar 13, 2024 at 12:36:58PM +0530, Umang Jain wrote:
> - Add dt-bindings documentation for Sony IMX283 sensor driver
> - Add MAINTAINERS entry for Sony IMX283 binding documentation
>
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/media/i2c/sony,imx283.yaml | 107 ++++++++++++++++++
> MAINTAINERS | 8 ++
> 2 files changed, 115 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
> new file mode 100644
> index 000000000000..e4f49f1435a5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
> @@ -0,0 +1,107 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2024 Ideas on Board Oy
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/sony,imx283.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sony IMX283 Sensor
> +
> +maintainers:
> + - Kieran Bingham <kieran.bingham@ideasonboard.com>
> + - Umang Jain <umang.jain@ideasonboard.com>
> +
> +description:
> + IMX283 sensor is a Sony CMOS active pixel digital image sensor with an active
> + array size of 5472H x 3648V. It is programmable through I2C interface. The
> + I2C client address is fixed to 0x1a as per sensor data sheet. Image data is
> + sent through MIPI CSI-2.
> +
> +properties:
> + compatible:
> + const: sony,imx283
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + description: Clock frequency from 6 to 24 MHz.
> + maxItems: 1
> +
> + vadd-supply:
> + description: Analog power supply (2.9V)
> +
> + vdd1-supply:
> + description: Interface power supply (1.8V)
> +
> + vdd2-supply:
> + description: Digital power supply (1.2V)

Those two supplies are named vddd1 and vddd2 in the datasheet.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +
> + reset-gpios:
> + description: Sensor reset (XCLR) GPIO
> + maxItems: 1
> +
> + port:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + additionalProperties: false
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + data-lanes:
> + anyOf:
> + - items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> +
> + link-frequencies: true
> +
> + required:
> + - data-lanes
> + - link-frequencies
> +
> + required:
> + - endpoint
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + camera@1a {
> + compatible = "sony,imx283";
> + reg = <0x1a>;
> + clocks = <&imx283_clk>;
> +
> + assigned-clocks = <&imx283_clk>;
> + assigned-clock-parents = <&imx283_clk_parent>;
> + assigned-clock-rates = <12000000>;
> +
> + vadd-supply = <&camera_vadd_2v9>;
> + vdd1-supply = <&camera_vdd1_1v8>;
> + vdd2-supply = <&camera_vdd2_1v2>;
> +
> + port {
> + imx283: endpoint {
> + remote-endpoint = <&cam>;
> + data-lanes = <1 2 3 4>;
> + link-frequencies = /bits/ 64 <360000000>;
> + };
> + };
> + };
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 73d898383e51..32f790c3a5f9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20368,6 +20368,14 @@ T: git git://linuxtv.org/media_tree.git
> F: Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> F: drivers/media/i2c/imx274.c
>
> +SONY IMX283 SENSOR DRIVER
> +M: Kieran Bingham <kieran.bingham@ideasonboard.com>
> +M: Umang Jain <umang.jain@ideasonboard.com>
> +L: linux-media@vger.kernel.org
> +S: Maintained
> +T: git git://linuxtv.org/media_tree.git
> +F: Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
> +
> SONY IMX290 SENSOR DRIVER
> M: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> L: linux-media@vger.kernel.org

--
Regards,

Laurent Pinchart