From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Markus Elfring <Markus.Elfring@web.de>,
linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: rcar-csi2: Use common error handling code in rcsi2_parse_dt()
Date: Sat, 16 Mar 2024 10:46:52 +0100 [thread overview]
Message-ID: <20240316094652.GC2092253@ragnatech.se> (raw)
In-Reply-To: <cc121bef-8bca-44e6-81aa-bf8e682bdaf5@moroto.mountain>
Hi Dan,
On 2024-03-04 14:16:56 +0300, Dan Carpenter wrote:
> On Mon, Mar 04, 2024 at 10:48:47AM +0000, Sakari Ailus wrote:
> > Hi Dan,
> >
> > On Fri, Mar 01, 2024 at 04:42:01PM +0300, Dan Carpenter wrote:
> > > Sakari Ailus pointed out in another thread that we could use __free()
> > > instead. Something like this:
> > >
> >
> > Looks good to me.
>
> Thanks for checking! I've never used these before.
>
> >
> > We could merge this with your SoB (pending Niklas's review). :-) The driver
> > has been since moved under drivers/media/platform/renesas/rcar-vin/ .
>
> Alright. I can resend this as a proper patch.
Please do.
I do find the idea of scoped operations and the syntax
struct fwnode_handle *fwnode __free(fwnode_handle) = NULL;
a bit foreign in a C context. But I think the intention is clear and it
allows us to avoid having the remember to free the fwnode in error paths
which is a nice thing.
>
> regards,
> dan carpenter
>
--
Kind Regards,
Niklas Söderlund
next prev parent reply other threads:[~2024-03-16 9:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 12:10 [PATCH] media: rcar-csi2: Use common error handling code in rcsi2_parse_dt() Markus Elfring
2024-03-01 13:05 ` Geert Uytterhoeven
2024-03-01 13:42 ` Dan Carpenter
2024-03-03 8:36 ` Markus Elfring
2024-03-04 10:48 ` Sakari Ailus
2024-03-04 11:16 ` Dan Carpenter
2024-03-16 9:46 ` Niklas Söderlund [this message]
2024-03-16 9:54 ` Dan Carpenter
2024-03-16 10:18 ` Niklas Söderlund
2024-03-16 12:21 ` Markus Elfring
2024-03-01 13:15 ` [PATCH] " Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240316094652.GC2092253@ragnatech.se \
--to=niklas.soderlund@ragnatech.se \
--cc=Markus.Elfring@web.de \
--cc=dan.carpenter@linaro.org \
--cc=geert@linux-m68k.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox