public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matt Ranostay <matt@ranostay.sg>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: health: maxim,max30102: fix compatible check
Date: Sun, 17 Mar 2024 14:37:39 +0000	[thread overview]
Message-ID: <20240317-bakery-numeric-a34b928efa6d@spud> (raw)
In-Reply-To: <20240316-max30102_binding_fix-v1-1-e8e58f69ef8a@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]

On Sat, Mar 16, 2024 at 11:56:57PM +0100, Javier Carrasco wrote:
> The "maxim,green-led-current-microamp" property is only available for
> the max30105 part (it provides an extra green LED), and must be set to
> false for the max30102 part.
> 
> Instead, the max30100 part has been used for that, which is not
> supported by this binding (it has its own binding).
> 
> This error was introduced during the txt to yaml conversion.
> 
> Fixes: 5a6a65b11e3a ("dt-bindings:iio:health:maxim,max30102: txt to yaml conversion")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

> ---
>  Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml b/Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml
> index c13c10c8d65d..eed0df9d3a23 100644
> --- a/Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml
> +++ b/Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml
> @@ -42,7 +42,7 @@ allOf:
>        properties:
>          compatible:
>            contains:
> -            const: maxim,max30100
> +            const: maxim,max30102
>      then:
>        properties:
>          maxim,green-led-current-microamp: false
> 
> ---
> base-commit: c1f10ac840caced7a9f717d4170dcc14b3fac076
> change-id: 20240316-max30102_binding_fix-898e7c94cce9
> 
> Best regards,
> -- 
> Javier Carrasco <javier.carrasco.cruz@gmail.com>
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-03-17 14:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-16 22:56 [PATCH] dt-bindings: iio: health: maxim,max30102: fix compatible check Javier Carrasco
2024-03-17 14:37 ` Conor Dooley [this message]
2024-03-24 11:07   ` Jonathan Cameron
2024-03-25 19:05     ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240317-bakery-numeric-a34b928efa6d@spud \
    --to=conor@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@ranostay.sg \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox