Re: [RFC PATCH net-next v4 04/11] net/smc: implement some unsupported operations of loopback-ism

Wen Gu
2024-03-22T01:39:45Z

On 2024/3/21 16:12, Jan Karcher wrote:
>
>
> On 17/03/2024 11:05, Wen Gu wrote:
>> vlan operations are not supported currently since the need for vlan in
>> loopback-ism situation does not seem to be strong.
>>
>> signal_event operation is not supported since no event now needs to be
>> processed by loopback-ism device.
>
> Hi Wen Gu,
>
> Could we re-phrase this commit message please? I had some trouble reading it. Maybe something along:
>
> Operations that loopback-ism does not support currently:
> - vlan operations, since there is no strong use-case for it
> - signal_event operations, since there are no events to be processed
>     by the loopback-ism device.
>
> Thanks
> - Jan
>
>>
>> Signed-off-by: Wen Gu <guwen@linux.alibaba.com>

OK, it will be improved as you suggested. Thanks!