Re: linux-next: build failure after merge of the btrfs-fixes tree

Re: linux-next: build failure after merge of the btrfs-fixes tree

[David Sterba]

On Tue, Jan 07, 2020 at 08:24:31AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the btrfs-fixes tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> fs/btrfs/inode.c: In function 'btrfs_unlink_subvol':
> fs/btrfs/inode.c:4283:16: error: 'inode' undeclared (first use in this function)
>  4283 |  if (btrfs_ino(inode) == BTRFS_EMPTY_SUBVOL_DIR_OBJECTID) {
>       |                ^~~~~
> 
> Caused by commit
> 
>   b225d1cb20cc ("btrfs: fix invalid removal of root ref")
> 
> I have reverted that commit for today.

Updated next-fixes branch pushed.

linux-next: build failure after merge of the btrfs-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 939 bytes --]

Hi all,

After merging the btrfs-fixes tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/btrfs/volumes.c: In function 'btrfs_scan_one_device':
fs/btrfs/volumes.c:1413:55: error: 'bdev_handle' undeclared (first use in this function)
 1413 |         if (btrfs_skip_registration(disk_super, path, bdev_handle->bdev->bd_dev,
      |                                                       ^~~~~~~~~~~
fs/btrfs/volumes.c:1413:55: note: each undeclared identifier is reported only once for each function it appears in

Caused by commit

  cc019bc0d55b ("btrfs: do not skip re-registration for the mounted device")

I have used the btrfs-fixes tree from next-20240315 for today.

This is actually caused by an interaction with commit

  9ae061cf2a46 ("btrfs: port device access to file")

which has been in Linus' tree since March 12 (and linux-next since Feb 26).
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the btrfs-fixes tree

[Anand Jain]

On 3/18/24 03:47, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the btrfs-fixes tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> fs/btrfs/volumes.c: In function 'btrfs_scan_one_device':
> fs/btrfs/volumes.c:1413:55: error: 'bdev_handle' undeclared (first use in this function)
>   1413 |         if (btrfs_skip_registration(disk_super, path, bdev_handle->bdev->bd_dev,
>        |                                                       ^~~~~~~~~~~
> fs/btrfs/volumes.c:1413:55: note: each undeclared identifier is reported only once for each function it appears in
> 
> Caused by commit
> 
>    cc019bc0d55b ("btrfs: do not skip re-registration for the mounted device")
> 
> I have used the btrfs-fixes tree from next-20240315 for today.
> 


> This is actually caused by an interaction with commit
> 
>    9ae061cf2a46 ("btrfs: port device access to file")
> 

Ah, unaware of this change. Thanks for the report.
A new fix, built on top of this change, has now been sent out.

As the Linux-next branch no longer has the commit cc019bc0d55b,
I've sent out the entire patch again.

https://lore.kernel.org/linux-btrfs/57a63f9905549f22618a85991b775fba76104412.1710732026.git.anand.jain@oracle.com/


Thanks, Anand

> which has been in Linus' tree since March 12 (and linux-next since Feb 26).

Re: linux-next: build failure after merge of the btrfs-fixes tree

[David Sterba]

On Mon, Mar 18, 2024 at 09:17:55AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the btrfs-fixes tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> fs/btrfs/volumes.c: In function 'btrfs_scan_one_device':
> fs/btrfs/volumes.c:1413:55: error: 'bdev_handle' undeclared (first use in this function)
>  1413 |         if (btrfs_skip_registration(disk_super, path, bdev_handle->bdev->bd_dev,
>       |                                                       ^~~~~~~~~~~
> fs/btrfs/volumes.c:1413:55: note: each undeclared identifier is reported only once for each function it appears in
> 
> Caused by commit
> 
>   cc019bc0d55b ("btrfs: do not skip re-registration for the mounted device")
> 
> I have used the btrfs-fixes tree from next-20240315 for today.
> 
> This is actually caused by an interaction with commit
> 
>   9ae061cf2a46 ("btrfs: port device access to file")
> 
> which has been in Linus' tree since March 12 (and linux-next since Feb 26).

I would really appreciate if all infrastructure changes to btrfs code
have CC:linux-btrfs@, the whole series "Open block devices as files" has
never been CCed so the build breakage is noticed only by accident. Also
I wonder why I have to repeatedly ask for that and why people think that
doing broad changes to code maintained by somebody else is ok.

There are 26 patches in linux-next intersecting fs/btrfs most of which I
see for the first time now. I don't have time to read fsdevel@ regularly
and act rather on events (i.e. CC or mails).

VFS is in the center of many other subsystems I understand that adding
the CC: manually is not feasible but scripting "if $path add CC:$subsys"
should be doable, namely when it's not just one-time job. Please try to
find some middle ground between efforts and patch workflow sanity.
Thanks for understanding.

Re: linux-next: build failure after merge of the btrfs-fixes tree

[David Sterba]

On Mon, Mar 18, 2024 at 09:17:55AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the btrfs-fixes tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> fs/btrfs/volumes.c: In function 'btrfs_scan_one_device':
> fs/btrfs/volumes.c:1413:55: error: 'bdev_handle' undeclared (first use in this function)
>  1413 |         if (btrfs_skip_registration(disk_super, path, bdev_handle->bdev->bd_dev,
>       |                                                       ^~~~~~~~~~~
> fs/btrfs/volumes.c:1413:55: note: each undeclared identifier is reported only once for each function it appears in

I've updated the for-next snapshot so it contains the updated version
that is based on top of the required changes. The same patch will be
also sent for merge.

linux-next: build failure after merge of the btrfs-fixes tree

[Mark Brown]

Hi all,

After merging the btrfs-fixes tree, today's linux-next build
(arm64 defconfig) failed like this:

/tmp/next/build/fs/btrfs/free-space-tree.c: In function 'btrfs_delete_orphan_free_space_entries':
/tmp/next/build/fs/btrfs/free-space-tree.c:1765:9: error: implicit declaration of function 'BTRFS_PATH_AUTO_RELEASE'; did you mean 'BTRFS_PATH_AUTO_FREE'? [-Wimplicit-function-declaration]
 1765 |         BTRFS_PATH_AUTO_RELEASE(path);
      |         ^~~~~~~~~~~~~~~~~~~~~~~
      |         BTRFS_PATH_AUTO_FREE
/tmp/next/build/fs/btrfs/free-space-tree.c:1765:33: error: 'path' undeclared (first use in this function)
 1765 |         BTRFS_PATH_AUTO_RELEASE(path);
      |                                 ^~~~
/tmp/next/build/fs/btrfs/free-space-tree.c:1765:33: note: each undeclared identifier is reported only once for each function it appears in
/tmp/next/build/fs/btrfs/free-space-tree.c:1817:1: error: control reaches end of non-void function [-Werror=return-type]
 1817 | }
      | ^
cc1: some warnings being treated as errors

Caused by commit

   7fcf8455f610b (btrfs: reject new transactions if the fs is fully read-only)

I have used the version from 20260119 instead.

Re: linux-next: build failure after merge of the btrfs-fixes tree

[Johannes Thumshirn]

On 1/20/26 1:08 PM, Mark Brown wrote:
> Hi all,
>
> After merging the btrfs-fixes tree, today's linux-next build
> (arm64 defconfig) failed like this:
>
> /tmp/next/build/fs/btrfs/free-space-tree.c: In function 'btrfs_delete_orphan_free_space_entries':
> /tmp/next/build/fs/btrfs/free-space-tree.c:1765:9: error: implicit declaration of function 'BTRFS_PATH_AUTO_RELEASE'; did you mean 'BTRFS_PATH_AUTO_FREE'? [-Wimplicit-function-declaration]
>   1765 |         BTRFS_PATH_AUTO_RELEASE(path);
>        |         ^~~~~~~~~~~~~~~~~~~~~~~
>        |         BTRFS_PATH_AUTO_FREE
> /tmp/next/build/fs/btrfs/free-space-tree.c:1765:33: error: 'path' undeclared (first use in this function)
>   1765 |         BTRFS_PATH_AUTO_RELEASE(path);
>        |                                 ^~~~
> /tmp/next/build/fs/btrfs/free-space-tree.c:1765:33: note: each undeclared identifier is reported only once for each function it appears in
> /tmp/next/build/fs/btrfs/free-space-tree.c:1817:1: error: control reaches end of non-void function [-Werror=return-type]
>   1817 | }
>        | ^
> cc1: some warnings being treated as errors
>
> Caused by commit
>
>     7fcf8455f610b (btrfs: reject new transactions if the fs is fully read-only)
>
> I have used the version from 20260119 instead.
>
This got introduced by

a08c5941d3ae ("btrfs: add mount time auto fix for orphan fst entries")

and 'BTRFS_PATH_AUTO_RELEASE()' got introduced by:

675af3c0fbd8 ("btrfs: introduce BTRFS_PATH_AUTO_RELEASE() helper")

which might be missing in for-next or btrfs-fixes?

Re: linux-next: build failure after merge of the btrfs-fixes tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

On Tue, Jan 20, 2026 at 12:22:37PM +0000, Johannes Thumshirn wrote:
> On 1/20/26 1:08 PM, Mark Brown wrote:

> > /tmp/next/build/fs/btrfs/free-space-tree.c:1765:33: error: 'path' undeclared (first use in this function)
> >   1765 |         BTRFS_PATH_AUTO_RELEASE(path);
> >        |                                 ^~~~

> This got introduced by

> a08c5941d3ae ("btrfs: add mount time auto fix for orphan fst entries")

> and 'BTRFS_PATH_AUTO_RELEASE()' got introduced by:

> 675af3c0fbd8 ("btrfs: introduce BTRFS_PATH_AUTO_RELEASE() helper")

> which might be missing in for-next or btrfs-fixes?

It's in for-next but not in btrfs-fixes.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the btrfs-fixes tree

[David Sterba]

On Tue, Jan 20, 2026 at 12:07:58PM +0000, Mark Brown wrote:
> Hi all,
> 
> After merging the btrfs-fixes tree, today's linux-next build
> (arm64 defconfig) failed like this:
> 
> /tmp/next/build/fs/btrfs/free-space-tree.c: In function 'btrfs_delete_orphan_free_space_entries':
> /tmp/next/build/fs/btrfs/free-space-tree.c:1765:9: error: implicit declaration of function 'BTRFS_PATH_AUTO_RELEASE'; did you mean 'BTRFS_PATH_AUTO_FREE'? [-Wimplicit-function-declaration]
>  1765 |         BTRFS_PATH_AUTO_RELEASE(path);
>       |         ^~~~~~~~~~~~~~~~~~~~~~~
>       |         BTRFS_PATH_AUTO_FREE
> /tmp/next/build/fs/btrfs/free-space-tree.c:1765:33: error: 'path' undeclared (first use in this function)
>  1765 |         BTRFS_PATH_AUTO_RELEASE(path);
>       |                                 ^~~~
> /tmp/next/build/fs/btrfs/free-space-tree.c:1765:33: note: each undeclared identifier is reported only once for each function it appears in
> /tmp/next/build/fs/btrfs/free-space-tree.c:1817:1: error: control reaches end of non-void function [-Werror=return-type]
>  1817 | }
>       | ^
> cc1: some warnings being treated as errors
> 
> Caused by commit
> 
>    7fcf8455f610b (btrfs: reject new transactions if the fs is fully read-only)
> 
> I have used the version from 20260119 instead.

Sorry, I'll drop the patch from next-fixes.

Re: linux-next: build failure after merge of the btrfs-fixes tree

[Qu Wenruo]

在 2026/1/21 02:48, David Sterba 写道:
> On Tue, Jan 20, 2026 at 12:07:58PM +0000, Mark Brown wrote:
>> Hi all,
>>
>> After merging the btrfs-fixes tree, today's linux-next build
>> (arm64 defconfig) failed like this:
>>
>> /tmp/next/build/fs/btrfs/free-space-tree.c: In function 'btrfs_delete_orphan_free_space_entries':
>> /tmp/next/build/fs/btrfs/free-space-tree.c:1765:9: error: implicit declaration of function 'BTRFS_PATH_AUTO_RELEASE'; did you mean 'BTRFS_PATH_AUTO_FREE'? [-Wimplicit-function-declaration]
>>   1765 |         BTRFS_PATH_AUTO_RELEASE(path);
>>        |         ^~~~~~~~~~~~~~~~~~~~~~~
>>        |         BTRFS_PATH_AUTO_FREE
>> /tmp/next/build/fs/btrfs/free-space-tree.c:1765:33: error: 'path' undeclared (first use in this function)
>>   1765 |         BTRFS_PATH_AUTO_RELEASE(path);
>>        |                                 ^~~~
>> /tmp/next/build/fs/btrfs/free-space-tree.c:1765:33: note: each undeclared identifier is reported only once for each function it appears in
>> /tmp/next/build/fs/btrfs/free-space-tree.c:1817:1: error: control reaches end of non-void function [-Werror=return-type]
>>   1817 | }
>>        | ^
>> cc1: some warnings being treated as errors
>>
>> Caused by commit
>>
>>     7fcf8455f610b (btrfs: reject new transactions if the fs is fully read-only)
>>
>> I have used the version from 20260119 instead.
> 
> Sorry, I'll drop the patch from next-fixes.

Or should I update the patch to use traditional manual path releasing?

As this one may need to be backported for older kernels.

Thanks,
Qu

linux-next: build failure after merge of the btrfs-fixes tree

[Mark Brown]

Hi all,

After merging the btrfs-fixes tree, today's linux-next build
(arm64 defconfig) failed like this:

/tmp/next/build/fs/btrfs/bio.c: In function 'btrfs_split_bio':
/tmp/next/build/fs/btrfs/bio.c:102:13: error: 'struct btrfs_bio' has no member named 'can_use_append'
  102 |         bbio->can_use_append = orig_bbio->can_use_append;
      |             ^~
/tmp/next/build/fs/btrfs/bio.c:102:41: error: 'struct btrfs_bio' has no member named 'can_use_append'
  102 |         bbio->can_use_append = orig_bbio->can_use_append;
      |                                         ^~
/tmp/next/build/fs/btrfs/bio.c:104:13: error: 'struct btrfs_bio' has no member named 'is_remap'
  104 |         bbio->is_remap = orig_bbio->is_remap;
      |             ^~
/tmp/next/build/fs/btrfs/bio.c:104:35: error: 'struct btrfs_bio' has no member named 'is_remap'
  104 |         bbio->is_remap = orig_bbio->is_remap;
      |                                   ^~

Caused by commit

   4b40b1c47f937 (btrfs: fix copying the flags of btrfs_bio after split)

I have used the version from 20260128 instead.

Re: linux-next: build failure after merge of the btrfs-fixes tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

On Thu, Jan 29, 2026 at 12:51:15PM +0000, Mark Brown wrote:
> Hi all,
> 
> After merging the btrfs-fixes tree, today's linux-next build
> (arm64 defconfig) failed like this:

This issue is still present in today's -next.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the btrfs-fixes tree

[David Sterba]

On Mon, Feb 02, 2026 at 02:57:25PM +0000, Mark Brown wrote:
> On Thu, Jan 29, 2026 at 12:51:15PM +0000, Mark Brown wrote:
> > Hi all,
> > 
> > After merging the btrfs-fixes tree, today's linux-next build
> > (arm64 defconfig) failed like this:
> 
> This issue is still present in today's -next.

I forgot to push the fixed branch, should be fixed in today's snapshot.
Thanks.