Re: [PATCH net] ice: Fix freeing uninitialized pointers

Dan Carpenter
2024-03-18T08:10:57Z

On Mon, Mar 18, 2024 at 08:58:24AM +0100, Jiri Pirko wrote:
> Sat, Mar 16, 2024 at 10:44:40AM CET, dan.carpenter@linaro.org wrote:
> >Automatically cleaned up pointers need to be initialized before exiting
> >their scope. In this case, they need to be initialized to NULL before
> >any return statement.
> >
> >Fixes: 90f821d72e11 ("ice: avoid unnecessary devm_ usage")
> >Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> >---
> > drivers/net/ethernet/intel/ice/ice_common.c | 4 ++--
> > drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> >diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c
> >index 4d8111aeb0ff..4b27d2bc2912 100644
> >--- a/drivers/net/ethernet/intel/ice/ice_common.c
> >+++ b/drivers/net/ethernet/intel/ice/ice_common.c
> >@@ -1002,8 +1002,8 @@ static void ice_get_itr_intrl_gran(struct ice_hw *hw)
> > */
> > int ice_init_hw(struct ice_hw *hw)
> > {
> >- struct ice_aqc_get_phy_caps_data *pcaps __free(kfree);
> >- void *mac_buf __free(kfree);
> >+ struct ice_aqc_get_phy_caps_data *pcaps __free(kfree) = NULL;
> >+ void *mac_buf __free(kfree) = NULL;
> > u16 mac_buf_len;
> > int status;
> >
>
> How about similar issues in:
> ice_set_fc()
> ice_cfg_phy_fec()
> ?

Yeah. Sorry, I'll resend. Smatch didn't warn about those bugs because
the sanity checks are the begining of the functions:

if (!pi || !aq_failures)
return -EINVAL;

are never true... It's the first time I've run into this as an issue.

regards,
dan carpenter