From: Jakub Kicinski <kuba@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Breno Leitao <leitao@debian.org>, Kalle Valo <kvalo@kernel.org>,
Jeff Johnson <jjohnson@kernel.org>,
keescook@chromium.org,
"open list:NETWORKING DRIVERS (WIRELESS)"
<linux-wireless@vger.kernel.org>,
"open list:QUALCOMM ATHEROS ATH11K WIRELESS DRIVER"
<ath11k@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath11k: allocate dummy net_device dynamically
Date: Thu, 21 Mar 2024 07:26:13 -0700 [thread overview]
Message-ID: <20240321072613.67466168@kernel.org> (raw)
In-Reply-To: <a44f21e3-1773-4b56-b1f0-c03a6462a7c1@gmail.com>
On Wed, 20 Mar 2024 07:05:42 -0700 Florian Fainelli wrote:
> > @@ -533,8 +534,11 @@ static int ath11k_ahb_config_ext_irq(struct ath11k_base *ab)
> >
> > irq_grp->ab = ab;
> > irq_grp->grp_id = i;
> > - init_dummy_netdev(&irq_grp->napi_ndev);
> > - netif_napi_add(&irq_grp->napi_ndev, &irq_grp->napi,
> > + irq_grp->napi_ndev = alloc_netdev(0, "dummy", NET_NAME_UNKNOWN,
> > + init_dummy_netdev);
>
> Is not this going to be a problem with multiple network device drivers
> loaded in a given system and all using "dummy" here? While
> NET_NAME_UNKNOWN ensures that this is not exposed to user-space, there
> is still this part of alloc_netdev_mqs() which is going to be non-unique:
>
> ref_tracker_dir_init(&dev->refcnt_tracker, 128, name);
Names are allocated are registration time, I think, so basically all
devices will get an non-uniquely named ref tracker dir. For ethernet
it will be unconverted "eth%d". The name only shows up in some prints,
AFAICT, so not very important?
next prev parent reply other threads:[~2024-03-21 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 18:57 [PATCH] wifi: ath11k: allocate dummy net_device dynamically Breno Leitao
2024-03-20 14:05 ` Florian Fainelli
2024-03-21 14:26 ` Jakub Kicinski [this message]
2024-03-20 14:32 ` Kalle Valo
2024-03-20 15:06 ` Jeff Johnson
2024-03-22 15:16 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240321072613.67466168@kernel.org \
--to=kuba@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=f.fainelli@gmail.com \
--cc=jjohnson@kernel.org \
--cc=keescook@chromium.org \
--cc=kvalo@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox