* [PATCH 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices @ 2024-03-20 12:43 INAGAKI Hiroshi 2024-03-20 12:43 ` [PATCH 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network INAGAKI Hiroshi 2024-03-20 12:43 ` [PATCH 2/2] dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN INAGAKI Hiroshi 0 siblings, 2 replies; 6+ messages in thread From: INAGAKI Hiroshi @ 2024-03-20 12:43 UTC (permalink / raw) To: pavel, lee, robh, krzysztof.kozlowski+dt, conor+dt Cc: linux-leds, devicetree, linux-kernel, INAGAKI Hiroshi This patch series adds some LED_FUNCTION_* definitions mainly for router devices. Those definitions are useful for OpenWrt or something. INAGAKI Hiroshi (2): dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN include/dt-bindings/leds/common.h | 3 +++ 1 file changed, 3 insertions(+) -- 2.25.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network 2024-03-20 12:43 [PATCH 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices INAGAKI Hiroshi @ 2024-03-20 12:43 ` INAGAKI Hiroshi 2024-03-21 13:55 ` Rob Herring 2024-03-20 12:43 ` [PATCH 2/2] dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN INAGAKI Hiroshi 1 sibling, 1 reply; 6+ messages in thread From: INAGAKI Hiroshi @ 2024-03-20 12:43 UTC (permalink / raw) To: pavel, lee, robh, krzysztof.kozlowski+dt, conor+dt Cc: linux-leds, devicetree, linux-kernel, INAGAKI Hiroshi, Hauke Mehrtens Add LED_FUNCTION_MOBILE for LEDs that indicate status of mobile network connection. As an example, "Mobile" LEDs on IIJ SA-W2 indicate status (no signal, too low, low, good) of mobile network connection via dongle connected to USB port. Suggested-by: Hauke Mehrtens <hauke@hauke-m.de> Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com> --- include/dt-bindings/leds/common.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h index ecea167930d9..d4b8498bde7f 100644 --- a/include/dt-bindings/leds/common.h +++ b/include/dt-bindings/leds/common.h @@ -91,6 +91,7 @@ #define LED_FUNCTION_LAN "lan" #define LED_FUNCTION_MAIL "mail" #define LED_FUNCTION_MTD "mtd" +#define LED_FUNCTION_MOBILE "mobile" #define LED_FUNCTION_PANIC "panic" #define LED_FUNCTION_PROGRAMMING "programming" #define LED_FUNCTION_RX "rx" -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network 2024-03-20 12:43 ` [PATCH 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network INAGAKI Hiroshi @ 2024-03-21 13:55 ` Rob Herring 2024-03-21 14:28 ` INAGAKI Hiroshi 0 siblings, 1 reply; 6+ messages in thread From: Rob Herring @ 2024-03-21 13:55 UTC (permalink / raw) To: INAGAKI Hiroshi Cc: pavel, lee, krzysztof.kozlowski+dt, conor+dt, linux-leds, devicetree, linux-kernel, Hauke Mehrtens On Wed, Mar 20, 2024 at 09:43:16PM +0900, INAGAKI Hiroshi wrote: > Add LED_FUNCTION_MOBILE for LEDs that indicate status of mobile network > connection. > As an example, "Mobile" LEDs on IIJ SA-W2 indicate status (no signal, > too low, low, good) of mobile network connection via dongle connected > to USB port. > > Suggested-by: Hauke Mehrtens <hauke@hauke-m.de> > Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com> > --- > include/dt-bindings/leds/common.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h > index ecea167930d9..d4b8498bde7f 100644 > --- a/include/dt-bindings/leds/common.h > +++ b/include/dt-bindings/leds/common.h > @@ -91,6 +91,7 @@ > #define LED_FUNCTION_LAN "lan" > #define LED_FUNCTION_MAIL "mail" > #define LED_FUNCTION_MTD "mtd" > +#define LED_FUNCTION_MOBILE "mobile" Why doesn't "wan" work? > #define LED_FUNCTION_PANIC "panic" > #define LED_FUNCTION_PROGRAMMING "programming" > #define LED_FUNCTION_RX "rx" > -- > 2.25.1 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network 2024-03-21 13:55 ` Rob Herring @ 2024-03-21 14:28 ` INAGAKI Hiroshi 0 siblings, 0 replies; 6+ messages in thread From: INAGAKI Hiroshi @ 2024-03-21 14:28 UTC (permalink / raw) To: Rob Herring Cc: pavel, lee, krzysztof.kozlowski+dt, conor+dt, linux-leds, devicetree, linux-kernel, Hauke Mehrtens Hello Rob Herring, thank you for your review. On 2024/03/21 22:55, Rob Herring wrote: > On Wed, Mar 20, 2024 at 09:43:16PM +0900, INAGAKI Hiroshi wrote: >> Add LED_FUNCTION_MOBILE for LEDs that indicate status of mobile network >> connection. >> As an example, "Mobile" LEDs on IIJ SA-W2 indicate status (no signal, >> too low, low, good) of mobile network connection via dongle connected >> to USB port. >> >> Suggested-by: Hauke Mehrtens <hauke@hauke-m.de> >> Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com> >> --- >> include/dt-bindings/leds/common.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h >> index ecea167930d9..d4b8498bde7f 100644 >> --- a/include/dt-bindings/leds/common.h >> +++ b/include/dt-bindings/leds/common.h >> @@ -91,6 +91,7 @@ >> #define LED_FUNCTION_LAN "lan" >> #define LED_FUNCTION_MAIL "mail" >> #define LED_FUNCTION_MTD "mtd" >> +#define LED_FUNCTION_MOBILE "mobile" > Why doesn't "wan" work? To distinguish the LEDs of mobile connection from the LEDs of wired wan connection. For example, IIJ SA-W2 also supports wan connection via the ethernet port "GE0" (WAN) in addition to mobile network. If "wan" is used, it may confuse users as to which connection the LED is for. BTW: _MOBILE should be placed before _MTD for alphabetical order, I'll fix it and send v2 patch series... > >> #define LED_FUNCTION_PANIC "panic" >> #define LED_FUNCTION_PROGRAMMING "programming" >> #define LED_FUNCTION_RX "rx" >> -- >> 2.25.1 >> Thanks, Hiroshi ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN 2024-03-20 12:43 [PATCH 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices INAGAKI Hiroshi 2024-03-20 12:43 ` [PATCH 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network INAGAKI Hiroshi @ 2024-03-20 12:43 ` INAGAKI Hiroshi 2024-03-22 14:54 ` Rob Herring 1 sibling, 1 reply; 6+ messages in thread From: INAGAKI Hiroshi @ 2024-03-20 12:43 UTC (permalink / raw) To: pavel, lee, robh, krzysztof.kozlowski+dt, conor+dt Cc: linux-leds, devicetree, linux-kernel, INAGAKI Hiroshi Add LED_FUNCTION_SPEED_LAN and LED_FUNCTION_SPEED_WAN for LEDs that indicate link speed of ethernet ports on LAN/WAN. This is useful to distinguish those LEDs from LEDs that indicate link status (up/down). example: Fortinet FortiGate 30E/50E have LEDs that indicate link speed on each of the ethernet ports in addition to LEDs that indicate link status (up/down). - 1000 Mbps: green:speed-(lan|wan)-N - 100 Mbps: amber:speed-(lan|wan)-N - 10 Mbps: (none, turned off) Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com> --- include/dt-bindings/leds/common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h index d4b8498bde7f..8d446cf88b4c 100644 --- a/include/dt-bindings/leds/common.h +++ b/include/dt-bindings/leds/common.h @@ -96,6 +96,8 @@ #define LED_FUNCTION_PROGRAMMING "programming" #define LED_FUNCTION_RX "rx" #define LED_FUNCTION_SD "sd" +#define LED_FUNCTION_SPEED_LAN "speed-lan" +#define LED_FUNCTION_SPEED_WAN "speed-wan" #define LED_FUNCTION_STANDBY "standby" #define LED_FUNCTION_TORCH "torch" #define LED_FUNCTION_TX "tx" -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN 2024-03-20 12:43 ` [PATCH 2/2] dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN INAGAKI Hiroshi @ 2024-03-22 14:54 ` Rob Herring 0 siblings, 0 replies; 6+ messages in thread From: Rob Herring @ 2024-03-22 14:54 UTC (permalink / raw) To: INAGAKI Hiroshi Cc: linux-kernel, devicetree, lee, krzysztof.kozlowski+dt, linux-leds, pavel, conor+dt On Wed, 20 Mar 2024 21:43:17 +0900, INAGAKI Hiroshi wrote: > Add LED_FUNCTION_SPEED_LAN and LED_FUNCTION_SPEED_WAN for LEDs that > indicate link speed of ethernet ports on LAN/WAN. This is useful to > distinguish those LEDs from LEDs that indicate link status (up/down). > > example: > > Fortinet FortiGate 30E/50E have LEDs that indicate link speed on each > of the ethernet ports in addition to LEDs that indicate link status > (up/down). > > - 1000 Mbps: green:speed-(lan|wan)-N > - 100 Mbps: amber:speed-(lan|wan)-N > - 10 Mbps: (none, turned off) > > Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com> > --- > include/dt-bindings/leds/common.h | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-03-22 14:54 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-03-20 12:43 [PATCH 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices INAGAKI Hiroshi 2024-03-20 12:43 ` [PATCH 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network INAGAKI Hiroshi 2024-03-21 13:55 ` Rob Herring 2024-03-21 14:28 ` INAGAKI Hiroshi 2024-03-20 12:43 ` [PATCH 2/2] dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN INAGAKI Hiroshi 2024-03-22 14:54 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox