From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BF691118C for ; Fri, 22 Mar 2024 07:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.198 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711092320; cv=none; b=tygHJkzVgQQFmXIRnnjAk8lWf5OrejqNooR9XD+6N9svCi4ofvNJ42p+mNC0UTlqiSQc9csGtysn856u73GtTt/HYDBENv9a/KaKYzgVkvCyAy3puozXt9bTi3lRBkwUcLsB0auu0OUxLo+81YSeZmA4A+pN2hUWCx0+AWgkscQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711092320; c=relaxed/simple; bh=E1HU3MaaZuurSbEALSn4O+2+Vq9VJFs+Q64NGMlxrrw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MZ9edbKcGktIw7jgs480t4XOOnFrXNjsoLNXkLk1Q/uZsRnXRNpkWfB2f28oPpt0z5whgxlFThvrxmo/F6aakahmPozNJLW9tN9gAeFRN+StGEGvWUrc0XOt1onRSpw024C3bFpQmJ3PueJdm8OydbcOhMwMCd6i3jst3sHGPyE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=CM9SHIfn; arc=none smtp.client-ip=217.70.183.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="CM9SHIfn" Received: by mail.gandi.net (Postfix) with ESMTPSA id D522AC0009; Fri, 22 Mar 2024 07:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1711092308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E1HU3MaaZuurSbEALSn4O+2+Vq9VJFs+Q64NGMlxrrw=; b=CM9SHIfnmGUNE1IzwOHvaAK1g9NZ1WvSYOa1vy60o/YQLH+EvEtHHb29PRtIBWb4L3RIDV 0PiXPywzFRxF9wikKti3xzriBzcF/sQezg97XH8ji5eFsS79+JbYiwlA50ozVpBGSUJTL0 87FqpXCjxeKhLVv9ok5FL2/DmyVXAtAKT0FD68aCxXgWObOW9eyubS1Jw9+qZZPOVzL1dO zu6WBd4zyihBgkUJVLxs0aOqzjad7LJgs2MdKNDE8XF9w6OO1c9In1GQ/E6jAzCsKOVrTJ OcJXrroAquMWl68MFgsx2UvUfun+9D+qHZV7M54eaPeQ5ZoTCdc0TW8GShIdzg== Date: Fri, 22 Mar 2024 08:25:06 +0100 From: Miquel Raynal To: Mikhail Kobuk Cc: Vinod Koul , Kishon Vijay Abraham I , Marek =?UTF-8?B?QmVow7pu?= , Pali =?UTF-8?B?Um9ow6Fy?= , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, Alexey Khoroshilov Subject: Re: [PATCH 1/2] phy: marvell: a3700-comphy: Fix out of bounds read Message-ID: <20240322082506.6d4cfa69@xps-13> In-Reply-To: <20240321164734.49273-1-m.kobuk@ispras.ru> References: <20240321164734.49273-1-m.kobuk@ispras.ru> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi Mikhail, m.kobuk@ispras.ru wrote on Thu, 21 Mar 2024 19:47:30 +0300: > There is an out of bounds read access of 'gbe_phy_init_fix[fix_idx].addr' > every iteration after 'fix_idx' reaches 'ARRAY_SIZE(gbe_phy_init_fix)'. >=20 > Make sure 'gbe_phy_init[addr]' is used when all elements of > 'gbe_phy_init_fix' array are handled. >=20 > Found by Linux Verification Center (linuxtesting.org) with SVACE. >=20 > Fixes: 934337080c6c ("phy: marvell: phy-mvebu-a3700-comphy: Add native ke= rnel implementation") > Signed-off-by: Mikhail Kobuk Reviewed-by: Miquel Raynal Thanks, Miqu=C3=A8l