Re: [PATCH v2 05/14] mm/ksm: use folio in stable_node_dup

Matthew Wilcox
2024-03-22T15:57:40Z

On Fri, Mar 22, 2024 at 04:36:52PM +0800, alexs@kernel.org wrote:
> -static struct page *stable_node_dup(struct ksm_stable_node **_stable_node_dup,
> - struct ksm_stable_node **_stable_node,
> - struct rb_root *root,
> - bool prune_stale_stable_nodes)
> +static void *stable_node_dup(struct ksm_stable_node **_stable_node_dup,
> + struct ksm_stable_node **_stable_node,
> + struct rb_root *root,
> + bool prune_stale_stable_nodes)

Do we really have to go through this void * stage?

Also, please stop reindenting the arguments. I tend to just switch to
two tabs, but lining them up with the opening bracket leads to extra
churn. Either leave them alone for the entire series or switch _once_.