From: Kees Cook <keescook@chromium.org>
To: Borislav Petkov <bp@alien8.de>
Cc: tglx@linutronix.de, Guixiong Wei <weiguixiong@bytedance.com>,
jgross@suse.com, mingo@redhat.com, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, peterz@infradead.org,
gregkh@linuxfoundation.org, tony.luck@intel.com,
adobriyan@gmail.com, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] x86, relocs: Ignore relocations in .notes section on walk_relocs
Date: Fri, 22 Mar 2024 16:40:11 -0700 [thread overview]
Message-ID: <202403221622.6EA43547F@keescook> (raw)
In-Reply-To: <20240322194658.GCZf3gMphnWeR9upN6@fat_crate.local>
On Fri, Mar 22, 2024 at 08:46:58PM +0100, Borislav Petkov wrote:
> On Tue, Mar 19, 2024 at 09:56:29AM -0700, Kees Cook wrote:
> > > Yes, please. Just send a Reviewed-by and it'll get picked up.
> >
> > Okay, thanks!
>
> Dammit, how did this commit land upstream and in stable?!
There are 2 related commits. This one ("... on walk_relocs") isn't in
Linus's tree nor stable.
(Thank you Ingo for taking it now.)
> Forgot to zap it from your tree and sent the branch to Linus anyway?
>
> Kees, please refrain from taking tip patches in the future. You know how
> this works - get_maintainers.pl.
The earlier patch, commit aaa8736370db ("x86, relocs: Ignore relocations
in .notes section"), landed via my tree. It was sent out on Feb 22nd
(v1[1]) and got a suggestion from HPA and a Review from Juergen Gross.
I sent v2 Feb 27th[2] and it sat ignored for two weeks. Since it was a
10 year old kernel address exposure, I sent it to Linus on Mar 12th[3].
-Kees
[1] https://lore.kernel.org/all/20240222171840.work.027-kees@kernel.org/
[2] https://lore.kernel.org/all/20240227175746.it.649-kees@kernel.org/
[3] https://lore.kernel.org/lkml/202403111702.828C918E55@keescook/
--
Kees Cook
next prev parent reply other threads:[~2024-03-22 23:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 15:05 [PATCH] x86, relocs: Ignore relocations in .notes section on walk_relocs Guixiong Wei
2024-03-18 21:40 ` Kees Cook
2024-03-18 21:56 ` Borislav Petkov
2024-03-18 23:45 ` Kees Cook
2024-03-19 8:16 ` Borislav Petkov
2024-03-19 16:56 ` Kees Cook
2024-03-22 19:46 ` Borislav Petkov
2024-03-22 23:40 ` Kees Cook [this message]
2024-03-23 10:38 ` Borislav Petkov
2024-03-25 20:23 ` Kees Cook
2024-03-22 8:45 ` Ingo Molnar
2024-03-22 23:41 ` Kees Cook
2024-03-24 3:57 ` [PATCH] x86/build: Clean up arch/x86/tools/relocs.c a bit Ingo Molnar
2024-03-22 8:56 ` [tip: x86/boot] x86/boot: Ignore relocations in .notes sections in walk_relocs() too tip-bot2 for Guixiong Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202403221622.6EA43547F@keescook \
--to=keescook@chromium.org \
--cc=adobriyan@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=weiguixiong@bytedance.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox