Re: siox patches for next development cycle [Re: [PATCH 0/4] siox: Move some complexity into the core]

Uwe Kleine-König
2024-03-07T07:08:43Z

[-- Attachment #1: Type: text/plain, Size: 2219 bytes --]

Hey Greg,

On Wed, Mar 06, 2024 at 10:46:43PM +0000, Greg Kroah-Hartman wrote:
> On Wed, Mar 06, 2024 at 07:24:38PM +0100, Uwe Kleine-König wrote:
> > On Tue, Feb 27, 2024 at 11:21:24AM +0100, Thorsten Scherer wrote:
> > > On Mon, Feb 19, 2024 at 08:46:28AM +0100, Uwe Kleine-König wrote:
> > > The series looks sensible.
> > >
> > > Acked-by: Thorsten Scherer <t.scherer@eckelmann.de>
> > >
> > > @gregkh: Would you please pick up Uwe's series as well?
> >
> > There are currently six patches for drivers/siox waiting to be applied.
> > (Two by Ricardo and four by me.) Thorsten asked Greg to do so. Greg
> > didn't pick these up yet though. So I collected them and put them to a
> > branch at:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git siox/for-next
> >
> > I'd like to get them in during the next development cycle.
> >
> > Greg, what is easiest for you? Are they still on your list of open
> > patches and we (I) need just a bit more patience? Or should I send a PR
> > to Linus when the merge window opens?
>
> Yes, they are on my list, but I am way behind, sorry. But hey, a pull
> request is faster, I'll go take this now, thanks!
>
> Oops, nope, I get the following build error with this tree:
> ERROR: modpost: "devm_siox_master_alloc" [drivers/siox/siox-bus-gpio.ko] undefined!
>
> So are you sure you tested this?

Dang, Stephen notices that, too. TIL if I only do:

make allmodconfig drivers/siox/

a missing EXPORT_SYMBOL doesn't make the build fail.

I squashed

diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c
index ae103349c91a..24a45920a240 100644
--- a/drivers/siox/siox-core.c
+++ b/drivers/siox/siox-core.c
@@ -730,6 +730,7 @@ struct siox_master *devm_siox_master_alloc(struct device *dev,

return smaster;
}
+EXPORT_SYMBOL_GPL(devm_siox_master_alloc);

int siox_master_register(struct siox_master *smaster)
{

into the offending commit in my above branch and did some more extensive
build testing.

Sorry
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]