From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3254C1272BB for ; Mon, 25 Mar 2024 15:49:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711381753; cv=none; b=r4vRRFe0Bz2Z+DE6iijicwjCHbu3xIL3brFCpgV0v/JWHkxRoeJoczEwodlKaz22ZIwXRS0YGKz1w728zMsfUqlTi9smCjZTMGBYrnJdeTLIV6XPHVfi0mugeIrXNfz6HEIjxHXJCUMTf0pTNL+Gex7hAGvMgpYLW5VZ4iSWr8w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711381753; c=relaxed/simple; bh=6xI3oxa/7z/SaAzm5xpMub07mC43yyFXlKvi9b83S68=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=klEyqpv+xfNEqT7xNZOjxhSDVzLJkNyjPl7ONVDEcJ56mLovnLF9h4a38ldsvFoEJuiLVwUcoSpJh6lRXc1ASgdEI/mO9/Z2OiEvQkdBtWQVHdgWQa5Vq9y4i9hNlufY+DGCN7d/1JtPTS3o4WoF/OgZZBCeRVXAQH1wd/GO7wU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=B4DoWmJv; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="B4DoWmJv" Received: by mail.gandi.net (Postfix) with ESMTPSA id 57EAF1C0008; Mon, 25 Mar 2024 15:49:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1711381749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6xI3oxa/7z/SaAzm5xpMub07mC43yyFXlKvi9b83S68=; b=B4DoWmJvW09wQ2VZhqZEJHEeiEapLvVpjavzV7e34afNsVTIQE6NnMd5XDeIfE4p/5NayX J1Ym22QC+UelmsfIuox1FKMj6+V8fY2GxkMhP8iI4Ii+ZeOAooRLf9ab5/fO4aOJTcpR7J MaukblEd1oZFBBpLk/172eFjrLoERtPmZ0CDeJtHTcW/xAqWfXSbkwVs/3tod1WPdyzBab CTbhehMgKJbliHIgVbz+4FTKSMeRQP6RsHKWVdIETB+bA0wk4m5MU7IbTMquGMWr7F/bk9 s0GGRZ8ym5ij9JKmT8/UV344PBIgSSFXNxrBv1/YZg17lGZiqbvtfLzkOZU0SA== Date: Mon, 25 Mar 2024 16:49:07 +0100 From: Miquel Raynal To: Andy Shevchenko Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Richard Weinberger , Vignesh Raghavendra Subject: Re: [PATCH v1 1/1] mtd: core: Align comment with an action in mtd_otp_nvmem_add() Message-ID: <20240325164907.0c8a89fb@xps-13> In-Reply-To: References: <20240325151150.3368658-1-andriy.shevchenko@linux.intel.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi Andy, andriy.shevchenko@linux.intel.com wrote on Mon, 25 Mar 2024 17:28:12 +0200: > On Mon, Mar 25, 2024 at 05:11:50PM +0200, Andy Shevchenko wrote: > > The comment is related to the non-error case, make it more clear > > by inverting the condition. It also makes code neater at the end. =20 >=20 > Just realized that even semantically it's better as it's done here > since we have an error path from which we exceptionally return successes > (in some cases). Tell me if I need to add this to the commit message. >=20 It's fine like that. Thanks, Miqu=C3=A8l