From: Greg KH <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Shahar Avidar <ikobh7@gmail.com>,
elder@linaro.org, robh@kernel.org,
parthiban.veerasooran@microchip.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] staging: pi433: Fix includes & macros.
Date: Mon, 25 Mar 2024 19:05:46 +0100 [thread overview]
Message-ID: <2024032520-implosion-living-d148@gregkh> (raw)
In-Reply-To: <ZgFBch_ccGnZBCmz@smile.fi.intel.com>
On Mon, Mar 25, 2024 at 11:18:42AM +0200, Andy Shevchenko wrote:
> On Sun, Mar 24, 2024 at 11:31:58AM +0200, Shahar Avidar wrote:
> > 1. Untangle include hierarchy.
> > 2. Update #minors the driver can accept.
> > 3. Make use of general macro instead of magic number.
>
> > Shahar Avidar (3):
> > staging: pi433: Use headers in appropriate files.
> > staging: pi433: Reduce N_PI433_MINORS to conform with N_SPI_MINORS.
> > staging: pi433: Make use of spi mode macro instead of magic number.
>
> For patches 1 and 3
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
That's impossible for b4 to parse, it would have applied this to all of
the commits if I had taken them :(
thanks,
greg k-h
next prev parent reply other threads:[~2024-03-25 18:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 9:31 [PATCH 0/3] staging: pi433: Fix includes & macros Shahar Avidar
2024-03-24 9:31 ` [PATCH 1/3] staging: pi433: Use headers in appropriate files Shahar Avidar
2024-03-24 9:32 ` [PATCH 2/3] staging: pi433: Reduce N_PI433_MINORS to conform with N_SPI_MINORS Shahar Avidar
2024-03-25 5:52 ` Dan Carpenter
2024-03-24 9:32 ` [PATCH 3/3] staging: pi433: Make use of spi mode macro instead of magic number Shahar Avidar
2024-03-25 9:18 ` [PATCH 0/3] staging: pi433: Fix includes & macros Andy Shevchenko
2024-03-25 18:05 ` Greg KH [this message]
2024-03-25 18:41 ` Andy Shevchenko
2024-03-25 18:51 ` Greg KH
2024-03-25 19:12 ` Andy Shevchenko
2024-03-26 6:01 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024032520-implosion-living-d148@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=elder@linaro.org \
--cc=ikobh7@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox