From: Shahar Avidar <ikobh7@gmail.com>
To: gregkh@linuxfoundation.org, elder@linaro.org,
andriy.shevchenko@linux.intel.com, robh@kernel.org,
parthiban.veerasooran@microchip.com
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/3] staging: pi433: Use headers in appropriate files.
Date: Wed, 27 Mar 2024 08:31:54 +0200 [thread overview]
Message-ID: <20240327063156.96307-2-ikobh7@gmail.com> (raw)
In-Reply-To: <20240327063156.96307-1-ikobh7@gmail.com>
Ensure rf69.c directly includes rf69_enum.h.
Move rf69_registers.h from header to the relevant source file.
Signed-off-by: Shahar Avidar <ikobh7@gmail.com>
---
drivers/staging/pi433/pi433_if.c | 1 +
drivers/staging/pi433/rf69.c | 1 +
drivers/staging/pi433/rf69.h | 1 -
3 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 81de98c0245a..0c12b31c4642 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -45,6 +45,7 @@
#include "pi433_if.h"
#include "rf69.h"
+#include "rf69_registers.h"
#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */
#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 5a1c362badb6..bf802f097310 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -11,6 +11,7 @@
#include <linux/units.h>
#include "rf69.h"
+#include "rf69_enum.h"
#include "rf69_registers.h"
#define F_OSC (32 * HZ_PER_MHZ)
diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h
index 76f0f9896a52..dd6fa8af9b9c 100644
--- a/drivers/staging/pi433/rf69.h
+++ b/drivers/staging/pi433/rf69.h
@@ -9,7 +9,6 @@
#define RF69_H
#include "rf69_enum.h"
-#include "rf69_registers.h"
#define FIFO_SIZE 66 /* bytes */
--
2.34.1
next prev parent reply other threads:[~2024-03-27 6:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 6:31 [PATCH v2 0/3] staging: pi433: Fix includes, comments & macros Shahar Avidar
2024-03-27 6:31 ` Shahar Avidar [this message]
2024-03-27 6:31 ` [PATCH v2 2/3] staging: pi433: Remove an inaccurate comment Shahar Avidar
2024-03-27 6:31 ` [PATCH v2 3/3] staging: pi433: Make use of spi mode macro instead of magic number Shahar Avidar
2024-03-27 13:10 ` [PATCH v2 0/3] staging: pi433: Fix includes, comments & macros Andy Shevchenko
2024-03-27 19:13 ` Shahar Avidar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327063156.96307-2-ikobh7@gmail.com \
--to=ikobh7@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=elder@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox