Re: [PATCH 4/5] bus: ti-sysc: Drop legacy quirk handling for smartreflex

Dhruva Gole
2024-03-28T11:23:57Z

Hi,

On Mar 27, 2024 at 10:15:07 +0200, Tony Lindgren wrote:
> With the smartreflex driver no longer relying on the use of
> pm_runtime_irq_safe(), we can finally drop the related legacy quirk
> handling.

Just for some more context can you describe from which commit of
smartreflex driver did this happen?

>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/bus/ti-sysc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -2869,8 +2869,7 @@ static const struct sysc_capabilities sysc_34xx_sr = {
> .type = TI_SYSC_OMAP34XX_SR,
> .sysc_mask = SYSC_OMAP2_CLOCKACTIVITY,
> .regbits = &sysc_regbits_omap34xx_sr,
> - .mod_quirks = SYSC_QUIRK_USE_CLOCKACT | SYSC_QUIRK_UNCACHED |
> - SYSC_QUIRK_LEGACY_IDLE,
> + .mod_quirks = SYSC_QUIRK_USE_CLOCKACT | SYSC_QUIRK_UNCACHED,
> };
>
> /*
> @@ -2891,13 +2890,12 @@ static const struct sysc_capabilities sysc_36xx_sr = {
> .type = TI_SYSC_OMAP36XX_SR,
> .sysc_mask = SYSC_OMAP3_SR_ENAWAKEUP,
> .regbits = &sysc_regbits_omap36xx_sr,
> - .mod_quirks = SYSC_QUIRK_UNCACHED | SYSC_QUIRK_LEGACY_IDLE,
> + .mod_quirks = SYSC_QUIRK_UNCACHED,
> };
>
> static const struct sysc_capabilities sysc_omap4_sr = {
> .type = TI_SYSC_OMAP4_SR,
> .regbits = &sysc_regbits_omap36xx_sr,
> - .mod_quirks = SYSC_QUIRK_LEGACY_IDLE,

I'm good with the changes,
Reviewed-by: Dhruva Gole <d-gole@ti.com>

--
Best regards,
Dhruva