Re: [PATCH] tg3: Remove residual error handling in tg3_suspend

Michael Chan
2024-03-07T22:38:16Z

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

On Thu, Mar 7, 2024 at 11:23 AM Nikita Kiryushin <kiryushin@ancud.ru> wrote:
>
>
> As of now, tg3_power_down_prepare always ends with success, but
> the error handling code from former tg3_set_power_state call is still here.
>
> Remove (now unreachable) code for simplification.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: c866b7eac073 ("tg3: Do not use legacy PCI power management")
> Signed-off-by: Nikita Kiryushin <kiryushin@ancud.ru>

The patch looks good to me. But I think we can go one step further
and change tg3_power_down_prepare() to a void function. Thanks.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]