From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83A25156F3A; Fri, 29 Mar 2024 12:31:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711715470; cv=none; b=Aj0mM5RknxoroScbmiHPlZuubVm7pYvl7s5rY3uQv+CMZxmz0dI8TNTVZxdbTmhpM267gh+3dfmqh7G86+A89vXOpoYKqQM5o434PXTYGkdME3fgt3bJ4+Zm/vTydgy+FZ7bNNHu0Z6m5zLLXLrTfevo3RfON+YULFayUd0YMTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711715470; c=relaxed/simple; bh=Kdyszlwq5JIK92eTlec4mtX/vVJlwIS0I5GaYJWP4a0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s0KEKNhMHd4usjdQ74HTr2uPxQcpxnZB7Ns9xWYLzgRXUx7y+OHlxMWEVJpD67+7f7Qwsi0EBXhBEPN0VPQGDg5qK41wLSIR7vPU5Xef2Bz/dO79oUhsywYmqGYIzShfTPnxn+/c4TiYW/ytZGO6iEVDYFV7GReA1UdvzjdORNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lNj3oRJY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lNj3oRJY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C819BC43394; Fri, 29 Mar 2024 12:31:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711715470; bh=Kdyszlwq5JIK92eTlec4mtX/vVJlwIS0I5GaYJWP4a0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lNj3oRJYzZdJNFr21Na411z/ilheIdmawWWwh4cS8SvNfpNji8v1u5GnOIbs4AdNX LZTSwOuQW8Yqm348dFkeEMXV7ffc1vOBrbXnWOf6beWz3Q3lwRQrMa6JfFNQGaNEq7 dP9de7I1RyaUJj6EoT+gD/S4ik6ekkl59105APISRHPM1EE6dBTihRnhYiLj86BZTq CHzGCjrCW0wvr2bvKVTRaBJ2oja5lzQ7mcCgSih38j4l89QRWgrNav3gKtao+8/5bF Jw58wXHzATwAVYIusbSDjiDJnaFXYRQLx0jtyky7QkJCk6ld0lZNjN/6vqbfx6bXIA cRO9gjBsF1f3Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Samasth Norway Ananda , "Rafael J . Wysocki" , Sasha Levin Subject: [PATCH AUTOSEL 6.6 34/52] tools/power x86_energy_perf_policy: Fix file leak in get_pkg_num() Date: Fri, 29 Mar 2024 08:29:04 -0400 Message-ID: <20240329122956.3083859-34-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240329122956.3083859-1-sashal@kernel.org> References: <20240329122956.3083859-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.23 Content-Transfer-Encoding: 8bit From: Samasth Norway Ananda [ Upstream commit f85450f134f0b4ca7e042dc3dc89155656a2299d ] In function get_pkg_num() if fopen_or_die() succeeds it returns a file pointer to be used. But fclose() is never called before returning from the function. Signed-off-by: Samasth Norway Ananda Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c index 5fd9e594079cf..ebda9c366b2ba 100644 --- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c +++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c @@ -1241,6 +1241,7 @@ unsigned int get_pkg_num(int cpu) retval = fscanf(fp, "%d\n", &pkg); if (retval != 1) errx(1, "%s: failed to parse", pathname); + fclose(fp); return pkg; } -- 2.43.0