From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E976D85947; Fri, 29 Mar 2024 12:32:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711715544; cv=none; b=S5i3TqFZvvFYk9vG6s9netg/39oRGjGqHssluA/PH3VryRshEmXhVlJgF36IdaLJPpo6hBiQvijkztFV1tXOFWxinCeKWE48oi47ShfDgYvIJGrQSWS6pkQjwu3mjCBRQvhzJDFb7pKfoPFre+EWPhqIaweyafZLSgmLALmArOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711715544; c=relaxed/simple; bh=Kx+1H+QtnuCB8ciX29fyhB79zT4Lxwy5pONlNfKxAiY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P+0BX15PwBJAKuEKnXsSrq9Y2JETGiPk+FmBDhlyG+FNh1M+8Pg9M4AY2z13eh5jZ0ytSqYr+5Dh0sCc6h9CrXH2hQhtBvQTPet/mEy4NViEl9OUddCUf0qBisxhM5szkpytPVC6ySf01OInLZTjBTB1qlfrN716N810Uwg8ClE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FjfCZSp+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FjfCZSp+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08A9FC433A6; Fri, 29 Mar 2024 12:32:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711715543; bh=Kx+1H+QtnuCB8ciX29fyhB79zT4Lxwy5pONlNfKxAiY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FjfCZSp+LMd4F7YfUcmRR8Xgk7/3nx6T7UYhN8/sav9hg8U7QVdz+PSCKwNlwM4dt xja3t+2tEdO6GYwZKFRcSIUkF91LnZx3fbw3f4UyKgwFjbku9jewGeA9R2jWdxhO7z vuHXdJJwg56DY0bEdx/LhcanXzz1ijXpYVCLBLmDACb8tj9N6Z8Sdsj23h0S50beot 6bb0BfcztITz20RBTsdR0cKjrovjV03v1/kVsWJ9vpvmS3ZR4Hm4m5l4ivgEQeo9NK zxrFaBXRyXazof29MLUN1IjiBUBe92ac6AfSPOVSXy1RbJn3kej+syPrQpDMj0UNgi 7shQYN51LGBRw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: C Cheng , Bo Ye , AngeloGioacchino Del Regno , "Rafael J . Wysocki" , Sasha Levin , rafael@kernel.org, daniel.lezcano@linaro.org, matthias.bgg@gmail.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH AUTOSEL 6.1 09/31] cpuidle: Avoid potential overflow in integer multiplication Date: Fri, 29 Mar 2024 08:31:28 -0400 Message-ID: <20240329123207.3085013-9-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240329123207.3085013-1-sashal@kernel.org> References: <20240329123207.3085013-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.83 Content-Transfer-Encoding: 8bit From: C Cheng [ Upstream commit 88390dd788db485912ee7f9a8d3d56fc5265d52f ] In detail: In C language, when you perform a multiplication operation, if both operands are of int type, the multiplication operation is performed on the int type, and then the result is converted to the target type. This means that if the product of int type multiplication exceeds the range that int type can represent, an overflow will occur even if you store the result in a variable of int64_t type. For a multiplication of two int values, it is better to use mul_u32_u32() rather than s->exit_latency_ns = s->exit_latency * NSEC_PER_USEC to avoid potential overflow happenning. Signed-off-by: C Cheng Signed-off-by: Bo Ye Reviewed-by: AngeloGioacchino Del Regno [ rjw: New subject ] Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/cpuidle/driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/cpuidle/driver.c b/drivers/cpuidle/driver.c index f70aa17e2a8e0..c594e28adddf3 100644 --- a/drivers/cpuidle/driver.c +++ b/drivers/cpuidle/driver.c @@ -16,6 +16,7 @@ #include #include #include +#include #include "cpuidle.h" @@ -185,7 +186,7 @@ static void __cpuidle_driver_init(struct cpuidle_driver *drv) s->target_residency_ns = 0; if (s->exit_latency > 0) - s->exit_latency_ns = s->exit_latency * NSEC_PER_USEC; + s->exit_latency_ns = mul_u32_u32(s->exit_latency, NSEC_PER_USEC); else if (s->exit_latency_ns < 0) s->exit_latency_ns = 0; } -- 2.43.0