From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 448FE16190E; Fri, 29 Mar 2024 12:33:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711715619; cv=none; b=ewvxCIuuHIr63hOyG18NLRzmL/D58GiDQ/NMi6dS24ZGtP4NR7gftHdaYJKezeZDbhdYTW2nmt+okZYfWCoGwrbUbqEwtG4DmqgmtTh2Hmi3GMwrvT+lHurh448j0wPgSuryIWIToE/43JgfZ4wAyTVwYF6bBFm0ZAwzvu2/6+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711715619; c=relaxed/simple; bh=Kdyszlwq5JIK92eTlec4mtX/vVJlwIS0I5GaYJWP4a0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T7Ihg5NOWYeBHbRnAiITuMa6wvqXwdVvUwsqmWUy0vXfRwZeKiZOhvyQXgxMmQa1zbAa5KfF91wjb0PKMKNC/EXA286ZOzq65t0/ZDZuad87C6m2UKQA1Czez6ItgQQVeyfYtm936SLHAHTA74R3WocoVrzhOOIJPGQJzmVfiCc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KyreAyEV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KyreAyEV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85556C43390; Fri, 29 Mar 2024 12:33:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711715619; bh=Kdyszlwq5JIK92eTlec4mtX/vVJlwIS0I5GaYJWP4a0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KyreAyEVJmGYD/x/vr52Ukq6ycN3knr8JzCKysnLDpEVTyO97c7w/NSDsKVcPXtc+ duE7utfrqppfnw4768qqNQ3fVLsNfPTjyieLO+KaTsWAJ4374oBVBTVLx0PtoARj00 PmGR9R/yAly3X+KIoV7DsCG7Gg9pUxRO0NoVMXOscf9/APZA6mXVo2ktDiW8/8TtTQ SktyTn2JIYc6ley6PtIYnIk+VQ/pGfTHQUisW+i2Dudsgit2/4Spj9EzqwZBR6H1Vn 20zYjf6ZXeQtKo9kpvc+XQAJjKr3GD9upPGoNSfdpmZx23jOPSRquznbgfntjccy/u WvWRZ3eaWZuhg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Samasth Norway Ananda , "Rafael J . Wysocki" , Sasha Levin Subject: [PATCH AUTOSEL 5.15 11/20] tools/power x86_energy_perf_policy: Fix file leak in get_pkg_num() Date: Fri, 29 Mar 2024 08:32:59 -0400 Message-ID: <20240329123316.3085691-11-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240329123316.3085691-1-sashal@kernel.org> References: <20240329123316.3085691-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.153 Content-Transfer-Encoding: 8bit From: Samasth Norway Ananda [ Upstream commit f85450f134f0b4ca7e042dc3dc89155656a2299d ] In function get_pkg_num() if fopen_or_die() succeeds it returns a file pointer to be used. But fclose() is never called before returning from the function. Signed-off-by: Samasth Norway Ananda Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c index 5fd9e594079cf..ebda9c366b2ba 100644 --- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c +++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c @@ -1241,6 +1241,7 @@ unsigned int get_pkg_num(int cpu) retval = fscanf(fp, "%d\n", &pkg); if (retval != 1) errx(1, "%s: failed to parse", pathname); + fclose(fp); return pkg; } -- 2.43.0