public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>,
	Josef Bacik <josef@toxicpanda.com>,
	Anand Jain <anand.jain@oracle.com>,
	Sasha Levin <sashal@kernel.org>,
	clm@fb.com, linux-btrfs@vger.kernel.org
Subject: [PATCH AUTOSEL 6.1 41/52] btrfs: export: handle invalid inode or root reference in btrfs_get_parent()
Date: Fri, 29 Mar 2024 08:45:35 -0400	[thread overview]
Message-ID: <20240329124605.3091273-41-sashal@kernel.org> (raw)
In-Reply-To: <20240329124605.3091273-1-sashal@kernel.org>

From: David Sterba <dsterba@suse.com>

[ Upstream commit 26b66d1d366a375745755ca7365f67110bbf6bd5 ]

The get_parent handler looks up a parent of a given dentry, this can be
either a subvolume or a directory. The search is set up with offset -1
but it's never expected to find such item, as it would break allowed
range of inode number or a root id. This means it's a corruption (ext4
also returns this error code).

Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 fs/btrfs/export.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/fs/btrfs/export.c b/fs/btrfs/export.c
index fab7eb76e53b2..58b0f04d7123f 100644
--- a/fs/btrfs/export.c
+++ b/fs/btrfs/export.c
@@ -161,8 +161,15 @@ struct dentry *btrfs_get_parent(struct dentry *child)
 	ret = btrfs_search_slot(NULL, root, &key, path, 0, 0);
 	if (ret < 0)
 		goto fail;
+	if (ret == 0) {
+		/*
+		 * Key with offset of -1 found, there would have to exist an
+		 * inode with such number or a root with such id.
+		 */
+		ret = -EUCLEAN;
+		goto fail;
+	}
 
-	BUG_ON(ret == 0); /* Key with offset of -1 found */
 	if (path->slots[0] == 0) {
 		ret = -ENOENT;
 		goto fail;
-- 
2.43.0


  parent reply	other threads:[~2024-03-29 12:47 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29 12:44 [PATCH AUTOSEL 6.1 01/52] drm/vc4: don't check if plane->state->fb == state->fb Sasha Levin
2024-03-29 12:44 ` [PATCH AUTOSEL 6.1 02/52] Input: synaptics-rmi4 - fail probing if memory allocation for "phys" fails Sasha Levin
2024-03-29 12:44 ` [PATCH AUTOSEL 6.1 03/52] drm: panel-orientation-quirks: Add quirk for GPD Win Mini Sasha Levin
2024-03-29 12:44 ` [PATCH AUTOSEL 6.1 04/52] arm64: dts: qcom: sdm630: add USB QMP PHY support Sasha Levin
2024-03-29 13:16   ` Konrad Dybcio
2024-04-08  2:07     ` Sasha Levin
2024-03-29 12:44 ` [PATCH AUTOSEL 6.1 05/52] arm64: dts: qcom: sda660-ifc6560: enable USB 3.0 PHY Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 06/52] pinctrl: renesas: checker: Limit cfg reg enum checks to provided IDs Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 07/52] VMCI: Fix memcpy() run-time warning in dg_dispatch_as_host() Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 08/52] sysv: don't call sb_bread() with pointers_lock held Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 09/52] quota: Fix potential NULL pointer dereference Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 10/52] scsi: lpfc: Fix possible memory leak in lpfc_rcv_padisc() Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 11/52] panic: Flush kernel log buffer at the end Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 12/52] isofs: handle CDs with bad root inode but good Joliet root directory Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 13/52] ASoC: Intel: common: DMI remap for rebranded Intel NUC M15 (LAPRC710) laptops Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 14/52] cpuidle: Avoid potential overflow in integer multiplication Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 15/52] arm64: dts: rockchip: fix rk3328 hdmi ports node Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 16/52] arm64: dts: rockchip: fix rk3399 " Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 17/52] rcu-tasks: Repair RCU Tasks Trace quiescence check Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 18/52] Julia Lawall reported this null pointer dereference, this should fix it Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 19/52] media: sta2x11: fix irq handler cast Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 20/52] ALSA: firewire-lib: handle quirk to calculate payload quadlets as data block counter Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 21/52] firmware: tegra: bpmp: Return directly after a failed kzalloc() in get_filename() Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 22/52] ext4: add a hint for block bitmap corrupt state in mb_groups Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 23/52] ext4: forbid commit inconsistent quota data when errors=remount-ro Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 24/52] drm/amd/display: Fix nanosec stat overflow Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 25/52] pstore/zone: Add a null pointer check to the psz_kmsg_read Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 26/52] tools/power x86_energy_perf_policy: Fix file leak in get_pkg_num() Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 27/52] drm/amd/amdgpu: Fix potential ioremap() memory leaks in amdgpu_device_init() Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 28/52] dma-direct: Leak pages on dma_set_decrypted() failure Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 29/52] SUNRPC: increase size of rpc_wait_queue.qlen from unsigned short to unsigned int Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 30/52] Revert "ACPI: PM: Block ASUS B1400CEAE from suspend to idle by default" Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 31/52] sparc: vdso: Disable UBSAN instrumentation Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 32/52] libperf evlist: Avoid out-of-bounds access Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 33/52] PCI: Mark LSI FW643 to avoid bus reset Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 34/52] cpufreq: Don't unregister cpufreq cooling on CPU hotplug Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 35/52] sh: Fix build with CONFIG_UBSAN=y Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 36/52] input/touchscreen: imagis: Correct the maximum touch area value Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 37/52] input/touchscreen: imagis: Add support for Imagis IST3038B Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 38/52] input/touchscreen: imagis: add support for IST3032C Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 39/52] btrfs: preallocate temporary extent buffer for inode logging when needed Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 40/52] btrfs: handle chunk tree lookup error in btrfs_relocate_sys_chunks() Sasha Levin
2024-03-29 12:45 ` Sasha Levin [this message]
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 42/52] btrfs: send: handle path ref underflow in header iterate_inode_ref() Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 43/52] block: prevent division by zero in blk_rq_stat_sum() Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 44/52] RDMA/cm: add timeout to cm_destroy_id wait Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 45/52] Input: make input_class constant Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 46/52] Input: imagis - use FIELD_GET where applicable Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 47/52] Input: imagis - add touch key support Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 48/52] Input: allocate keycode for Display refresh rate toggle Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 49/52] platform/x86: touchscreen_dmi: Add an extra entry for a variant of the Chuwi Vi8 tablet Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 50/52] perf/x86/amd/lbr: Discard erroneous branch entries Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 51/52] ktest: force $buildonly = 1 for 'make_warnings_file' test type Sasha Levin
2024-03-29 12:45 ` [PATCH AUTOSEL 6.1 52/52] ring-buffer: use READ_ONCE() to read cpu_buffer->commit_page in concurrent environment Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240329124605.3091273-41-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=anand.jain@oracle.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox