From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Takashi Sakamoto <o-takashi@sakamocchi.jp>,
Takashi Iwai <tiwai@suse.de>, Sasha Levin <sashal@kernel.org>,
clemens@ladisch.de, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org
Subject: [PATCH AUTOSEL 5.15 13/34] ALSA: firewire-lib: handle quirk to calculate payload quadlets as data block counter
Date: Fri, 29 Mar 2024 08:47:14 -0400 [thread overview]
Message-ID: <20240329124750.3092394-13-sashal@kernel.org> (raw)
In-Reply-To: <20240329124750.3092394-1-sashal@kernel.org>
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
[ Upstream commit 4a486439d2ca85752c46711f373b6ddc107bb35d ]
Miglia Harmony Audio (OXFW970) has a quirk to put the number of
accumulated quadlets in CIP payload into the dbc field of CIP header.
This commit handles the quirk in the packet processing layer.
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20240218074128.95210-4-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
sound/firewire/amdtp-stream.c | 12 ++++++++----
sound/firewire/amdtp-stream.h | 4 ++++
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/sound/firewire/amdtp-stream.c b/sound/firewire/amdtp-stream.c
index f8b644cb9157a..8753125683692 100644
--- a/sound/firewire/amdtp-stream.c
+++ b/sound/firewire/amdtp-stream.c
@@ -771,10 +771,14 @@ static int check_cip_header(struct amdtp_stream *s, const __be32 *buf,
} else {
unsigned int dbc_interval;
- if (*data_blocks > 0 && s->ctx_data.tx.dbc_interval > 0)
- dbc_interval = s->ctx_data.tx.dbc_interval;
- else
- dbc_interval = *data_blocks;
+ if (!(s->flags & CIP_DBC_IS_PAYLOAD_QUADLETS)) {
+ if (*data_blocks > 0 && s->ctx_data.tx.dbc_interval > 0)
+ dbc_interval = s->ctx_data.tx.dbc_interval;
+ else
+ dbc_interval = *data_blocks;
+ } else {
+ dbc_interval = payload_length / sizeof(__be32);
+ }
lost = dbc != ((*data_block_counter + dbc_interval) & 0xff);
}
diff --git a/sound/firewire/amdtp-stream.h b/sound/firewire/amdtp-stream.h
index 1f957c946c956..cf9ab347277f2 100644
--- a/sound/firewire/amdtp-stream.h
+++ b/sound/firewire/amdtp-stream.h
@@ -37,6 +37,9 @@
* the value of current SYT_INTERVAL; e.g. initial value is not zero.
* @CIP_UNAWARE_SYT: For outgoing packet, the value in SYT field of CIP is 0xffff.
* For incoming packet, the value in SYT field of CIP is not handled.
+ * @CIP_DBC_IS_PAYLOAD_QUADLETS: Available for incoming packet, and only effective with
+ * CIP_DBC_IS_END_EVENT flag. The value of dbc field is the number of accumulated quadlets
+ * in CIP payload, instead of the number of accumulated data blocks.
*/
enum cip_flags {
CIP_NONBLOCKING = 0x00,
@@ -51,6 +54,7 @@ enum cip_flags {
CIP_NO_HEADER = 0x100,
CIP_UNALIGHED_DBC = 0x200,
CIP_UNAWARE_SYT = 0x400,
+ CIP_DBC_IS_PAYLOAD_QUADLETS = 0x800,
};
/**
--
2.43.0
next prev parent reply other threads:[~2024-03-29 12:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 12:47 [PATCH AUTOSEL 5.15 01/34] Input: synaptics-rmi4 - fail probing if memory allocation for "phys" fails Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 02/34] pinctrl: renesas: checker: Limit cfg reg enum checks to provided IDs Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 03/34] VMCI: Fix memcpy() run-time warning in dg_dispatch_as_host() Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 04/34] sysv: don't call sb_bread() with pointers_lock held Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 05/34] quota: Fix potential NULL pointer dereference Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 06/34] scsi: lpfc: Fix possible memory leak in lpfc_rcv_padisc() Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 07/34] panic: Flush kernel log buffer at the end Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 08/34] isofs: handle CDs with bad root inode but good Joliet root directory Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 09/34] cpuidle: Avoid potential overflow in integer multiplication Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 10/34] arm64: dts: rockchip: fix rk3328 hdmi ports node Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 11/34] arm64: dts: rockchip: fix rk3399 " Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 12/34] media: sta2x11: fix irq handler cast Sasha Levin
2024-03-29 12:47 ` Sasha Levin [this message]
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 14/34] ext4: add a hint for block bitmap corrupt state in mb_groups Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 15/34] ext4: forbid commit inconsistent quota data when errors=remount-ro Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 16/34] drm/amd/display: Fix nanosec stat overflow Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 17/34] pstore/zone: Add a null pointer check to the psz_kmsg_read Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 18/34] tools/power x86_energy_perf_policy: Fix file leak in get_pkg_num() Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 19/34] SUNRPC: increase size of rpc_wait_queue.qlen from unsigned short to unsigned int Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 20/34] Revert "ACPI: PM: Block ASUS B1400CEAE from suspend to idle by default" Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 21/34] sparc: vdso: Disable UBSAN instrumentation Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 22/34] libperf evlist: Avoid out-of-bounds access Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 23/34] PCI: Mark LSI FW643 to avoid bus reset Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 24/34] sh: Fix build with CONFIG_UBSAN=y Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 25/34] btrfs: handle chunk tree lookup error in btrfs_relocate_sys_chunks() Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 26/34] btrfs: export: handle invalid inode or root reference in btrfs_get_parent() Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 27/34] btrfs: send: handle path ref underflow in header iterate_inode_ref() Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 28/34] block: prevent division by zero in blk_rq_stat_sum() Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 29/34] RDMA/cm: add timeout to cm_destroy_id wait Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 30/34] Input: make input_class constant Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 31/34] Input: allocate keycode for Display refresh rate toggle Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 32/34] platform/x86: touchscreen_dmi: Add an extra entry for a variant of the Chuwi Vi8 tablet Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 33/34] ktest: force $buildonly = 1 for 'make_warnings_file' test type Sasha Levin
2024-03-29 12:47 ` [PATCH AUTOSEL 5.15 34/34] ring-buffer: use READ_ONCE() to read cpu_buffer->commit_page in concurrent environment Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240329124750.3092394-13-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox