From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D00A81BC156; Fri, 29 Mar 2024 12:51:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711716667; cv=none; b=PZanJUzBPDChwVLATLpZ0XujZNhHxArpTDqM2QqJH7x5X/BerbQqGXbIQRJDdaxz1BdE+LiLqtmQIq5J/MInpvMgawQA6VEQYwsYgNvTc/DhjuKp/gBwVCPsCcKV8ZvDS/iT2IMs0pUX5I7rIY0loxY1PqbhnGTbZ3PU3y+ufjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711716667; c=relaxed/simple; bh=WITtngLLG38kILuuI51urHZWyDVZckECn0zeZ6vqb8M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Mn4Lg1J1Ne5HaRiDOCUliL8AIs/PFgzzB179sfv/GAQJg11udeMriEBHwPcc5Q8o9YsFFO6M6tJaN8iZOVovCVb0PAx1LVd8TANws9YAy5EGpAYj0oOlfDuHr5/N2eNZ9F6+lsz01SyqNfws2YbBynR2rqt7674RSm5nFfYJYnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d47z49V9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d47z49V9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E9EEC433A6; Fri, 29 Mar 2024 12:51:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711716667; bh=WITtngLLG38kILuuI51urHZWyDVZckECn0zeZ6vqb8M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d47z49V9nwITS5amyVHNiNiYEHNG6iXRnHRdr6DY/9M8IjvUi8E4Z5/nvzWPwdfK8 IkhRFPOjEHFxp+NISSSxic3twxO8fETKBKNL7GYosByiz5FOlVw3oX8ZC63fLOCcNn 3drnOh0jExZBVthRUtmFfuo9sRaKGLFB2NTvq6ZrrYb3U1R/qv6CygYh/LcEJPMFgs ZwquNJoZR3tn2b7L4fHinrTfwHhu3uKI79Bvmj2PIJdS1Gsx/zsRh+RRwfyFDYip7Q r8FTfpG+cg+MGQipEL8XmnMNDf6CHGTdFeDxPEqDgbUWBRChS7WWQmrHLi8qVeDTdi LmSbdE1Qufrvw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Justin Tee , Himanshu Madhani , "Martin K . Petersen" , Sasha Levin , james.smart@broadcom.com, dick.kennedy@broadcom.com, jejb@linux.ibm.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 04/19] scsi: lpfc: Fix possible memory leak in lpfc_rcv_padisc() Date: Fri, 29 Mar 2024 08:50:36 -0400 Message-ID: <20240329125100.3094358-4-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240329125100.3094358-1-sashal@kernel.org> References: <20240329125100.3094358-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.311 Content-Transfer-Encoding: 8bit From: Justin Tee [ Upstream commit 2ae917d4bcab80ab304b774d492e2fcd6c52c06b ] The call to lpfc_sli4_resume_rpi() in lpfc_rcv_padisc() may return an unsuccessful status. In such cases, the elsiocb is not issued, the completion is not called, and thus the elsiocb resource is leaked. Check return value after calling lpfc_sli4_resume_rpi() and conditionally release the elsiocb resource. Signed-off-by: Justin Tee Link: https://lore.kernel.org/r/20240131185112.149731-3-justintee8345@gmail.com Reviewed-by: Himanshu Madhani Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/lpfc/lpfc_nportdisc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c index f666518d84b0a..0890c2e38eeca 100644 --- a/drivers/scsi/lpfc/lpfc_nportdisc.c +++ b/drivers/scsi/lpfc/lpfc_nportdisc.c @@ -601,8 +601,10 @@ lpfc_rcv_padisc(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp, /* Save the ELS cmd */ elsiocb->drvrTimeout = cmd; - lpfc_sli4_resume_rpi(ndlp, - lpfc_mbx_cmpl_resume_rpi, elsiocb); + if (lpfc_sli4_resume_rpi(ndlp, + lpfc_mbx_cmpl_resume_rpi, + elsiocb)) + kfree(elsiocb); goto out; } } -- 2.43.0